[pull] master from mattermost:master - #924
Merged
Merged
Conversation
* Update RB to latest version of fork * Update most snapshots to remove extraneous div * Forward ref to menu passed to RB Dropdown * Update unusual tests broken by RB update * Patch react-overlays to still close modal when default prevented The old version of react-overlays that we had ignored this, but the newer version causes the modal to not close when preventDefault is called on the escape keyboard event. React Select always does that and some other components like the SuggestionBox sometimes prevent default, and it doesn't seem like Floating UI or MUI look at preventDefault to know whether or not to close the modal, so I think React Overlays is the correct place for this patch. * Remove @types/react-overlays in favour of built-in definitions * Update RB to merged commit
…b Server (#38026) * [MM-57806] Graduate Enable Channel Viewed WebSocket Messages Move ServiceSettings.EnableChannelViewedMessages out of System Console > Experimental > Features and into Environment > Web Server, alongside the other ServiceSettings transport and performance knobs it belongs with. The access tag changes from experimental_features to environment_web_server, so the setting is now governed by sysconsole_read/write_environment_web_server. write_restrictable and cloud_restrictable are preserved, the default remains true, and the client config continues to publish the value. No runtime behavior changes. The i18n ids move from the admin.experimental.* namespace to the admin.service.* namespace used by the rest of the Web Server page. * [MM-57806] Document channel viewed WebSocket messages under Environment Move the Enable Channel Viewed WebSocket Messages entry from the experimental configuration settings page to the Web Server section of the environment configuration settings page, matching its new System Console location, and reformat it to the two-column table style used there. * [MM-57806] Cover the new location of the channel viewed setting Assert that the setting is defined on the Environment > Web Server page, that it is gated on write access to the Web Server console resource rather than to Experimental Features, and that searching the admin console for "channel_viewed" resolves to environment/web_server. --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )