[pull] master from mattermost:master - #925
Merged
Merged
Conversation
…ization (#38027) * [MM-57808][MM-57809][MM-57811] Graduate theme settings to Site Configuration > Customization Move ThemeSettings.EnableThemeSelection, ThemeSettings.AllowCustomThemes, and ThemeSettings.DefaultTheme out of System Console > Experimental > Features and into Site Configuration > Customization, alongside the other branding settings. The config keys, defaults, license gating, and the AllowCustomThemes dependency on EnableThemeSelection are unchanged; only the System Console page and the access classification move. The access tags become site_customization, so the settings are now governed by sysconsole_{read,write}_site_customization rather than sysconsole_{read,write}_experimental_features. i18n ids move from admin.experimental.* to the Customization page's admin.customization.* convention, and the documentation entries move from the experimental configuration settings page to the site configuration settings page. * [MM-57812][MM-57813] Graduate tutorial and onboarding settings to Site Configuration > Customization Move ServiceSettings.EnableTutorial and ServiceSettings.EnableOnboardingFlow out of System Console > Experimental > Features and into Site Configuration > Customization, next to the desktop app landing page setting that also governs a user's first-run experience. The config keys and defaults are unchanged; only the System Console page and the access classification move. The access tags become site_customization, so the settings are now governed by sysconsole_{read,write}_site_customization rather than sysconsole_{read,write}_experimental_features. i18n ids move from admin.experimental.* to the Customization page's admin.customization.* convention, and the documentation entries move from the experimental configuration settings page to the site configuration settings page. * [MM-57810] Surface ThemeSettings.AllowedThemes in Site Configuration > Customization ThemeSettings.AllowedThemes has always existed in the server config and has always been honoured by the theme picker, but it was never represented in the System Console schema — not under Experimental > Features and not anywhere else. Add it to Site Configuration > Customization alongside the theme settings it constrains. The server model is []string, so this uses the existing `type: 'text'` with `multiple: true` widget, the same one ServiceSettings.DCRRedirectURIAllowlist uses for its []string. The admin console joins the array with commas for display and splits it back into an array on save, which matches how the client config already serialises the value, so no behaviour or serialisation changes. The setting picks up an access tag of site_customization, where it previously had none, and the documentation entry moves from the self-hosted-only section of the experimental configuration settings page to the site configuration settings page. Also add a test asserting the graduated settings are present on Customization, absent from Experimental > Features, and that AllowedThemes round-trips as a string array. * Add runtime-effect tests for graduated theme and onboarding settings Expand coverage for the graduated Customization settings so that they are verified to affect their features, not just to save: - ThemeSettings.AllowedThemes: premade theme chooser only renders the allow-listed themes (theme enforcement on/off). - ServiceSettings.EnableOnboardingFlow: onboarding task list is gated on the config value. - ServiceSettings.EnableTutorial: the Channels tour tip is gated on the config value. - EnableTutorial/EnableOnboardingFlow (and the theme bools) round-trip their value through the admin console schema. Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com> Co-authored-by: Jesse Hallam <lieut-data@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )