[pull] master from mozilla:master - #501
Merged
Merged
Conversation
Serialized OBJR children used raw object references that do not match annotation-layer element IDs. Type correction also required a structure element to have exactly one child, so links with marked content were missed. Match OBJR children to annotations by object reference. Keep structured annotations owned by the structure tree, and use text-layer positioning only for annotations absent from it.
In a few spots we can directly pass the function, and don't need to create an "intermediate" arrow function.
… values There are some spots where we want to filter out any truthy values, where that's currently done with an arrow function. Those cases can instead use `Boolean` as the callback function, which is a pattern that newer parts of the code-base is already using.
Shorten some `Array.prototype.map()` callbacks
Use `Array.prototype.filter(Boolean)` more, when filtering out truthy values
Nova-ify the viewer (bug 2063405)
Modernize the `XRefMock` unit-test helper
Use the structure tree to position annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )