[pull] master from mozilla:master - #504
Merged
Merged
Conversation
According to the coverage data this is now dead code; see https://app.codecov.io/gh/mozilla/pdf.js/commit/6694c0eca8c80e3b0aaefa1ad3b76d9317ab2466/blob/src/core/lzw_stream.js?dropdown=coverage#L69 The reason that this check isn't necessary is that the `DecodeStream` class always checks that `!this.eof` holds *before* invoking the `readBlock` method. Looking at the other `DecodeStream` sub-classes they generally rely on this fact, since there's no other `readBlock` implementation with a similar check. Finally, note that `this.lzwState` is only removed in a single case where `this.eof = true;` is also being set; see https://github.com/mozilla/pdf.js/blob/6694c0eca8c80e3b0aaefa1ad3b76d9317ab2466/src/core/lzw_stream.js#L108-L112
Remove unnecessary `!lzwState` check in `LZWStream.prototype.readBlock`
Avoid rendering every page for content assertions and read text through the reordered page-view proxies. Wait for the views manager to finish opening, target a stable drag slot, synchronize current-page checks, and handle cloned annotation storage IDs.
The chevron and the header padding used physical properties, so they didn't mirror in RTL: the chevron ended up flush against the pages icon and the selector and trailing buttons had their insets swapped. The menu check mark is a "V" shaped glyph, hence it must be mirrored too, as it's already done for the check mark of the signature properties.
The toolbar is appended to the text layer, which is always LTR (see `.pdfViewer .page`), hence the `inset-inline-end` used to position it always resolved to `right` while in RTL the anchor point is the left edge of the selection: the toolbar ended up on the other side of the page. The annotation editor layer already sets its own direction, so just do the same here.
Fix the RTL layout of the views manager header (bug 2060033)
Set the direction of the floating toolbar in RTL locales (bug 2060032)
…test Fix intermittent reorganize pages integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )