[pull] main from microsoft:main - #1595
Merged
Merged
Conversation
…331045) * agentHost: Don't split the final response at the reconnect boundary Reconnecting to an active turn ran two independent converters over the same response parts: the one-shot `activeTurnToProgress` snapshot and the always-on `_observeTurn` graph. They de-duplicate via `adoptInvocations`, which is keyed on live `ChatToolInvocation` instances — so a tool call that had already settled, and which the snapshot renders as a `toolInvocationSerialized` part, could not be adopted and was emitted a second time as a live invocation. That duplicate lands between the restored markdown prefix and the markdown still streaming into the same response part. The response model only merges a markdown update into an immediately preceding markdown part, so the final answer was split in two — in the observed case mid-word, with the prefix folded into the collapsed activity section and the remainder rendered as a separate response. Record what the snapshot emitted per tool call instead of only the adoptable subset, so per-tool setup can skip a settled tool call that is already fully rendered. Subagent tools are excluded because their setup is what streams the child session's inner tool calls into the response. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Don't re-emit a settled subagent parent card on reconnect Code review caught that the subagent exception left the reconnect split in place for completed subagent calls: the guard declined to skip them so their child session would still be observed, but that fell through to `_setupServerToolCall`, which sinks a second live parent invocation. That part lands between the restored markdown prefix and its continuation — the very split the guard exists to prevent. Separate child-session observation from emitting the parent invocation. The invocation is still built so subagent observation has something to drive, but a tool call the snapshot already rendered as a serialized part is no longer emitted a second time. Also trims the inline commentary flagged in review. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: track Copilot client startup outcomes Emit one terminal startup event per Copilot client attempt and separate startup failures from established-client operation failures. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: address startup telemetry review Make startup failure classification consistent and remove timing-sensitive test cleanup. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: structure startup error classification Use a typed VS Code startup error and centralize SDK message classification. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: Respect telemetry disablement during initialization Send each client's effective telemetry level with initialize and reconnect so the host applies consent before connection telemetry or queued actions. Keep the host disabled until a client level arrives, and propagate process-level restrictions to generic remote telemetry.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Preserve telemetry wrapper defaults for direct callers Keep fail-closed startup explicit to the production factory while preserving the established constructor behavior used by isolated Agent Host components and tests.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Gate telemetry on client consent Keep seeded root configuration from enabling telemetry before initialize or reconnect provides a client telemetry level. Preserve existing direct-construction defaults for isolated callers and tests.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Propagate telemetry level at process launch Start controlled Agent Host processes with the launcher's effective telemetry level so opted-in clients retain early diagnostics while opted-out clients disable telemetry before startup. Keep initialize and reconnect updates as a monotonic multi-client clamp across local, remote-server, SSH, WSL, and CLI-supervised hosts.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update generated extension point cache Include the link presentation provider extension point generated by hygiene after merging origin/main.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Derive SSH telemetry in shared process Use the shared process telemetry service when launching SSH and WSL Agent Hosts instead of threading the telemetry level through renderer IPC contracts.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )