[pull] main from microsoft:main - #1605
Merged
Merged
Conversation
* sessions: remove gaps above docked file trees Align the docked details pane with the actual editor title boundary and remove legacy outer/internal spacing from single-pane Changes views. Update the Changes fixture to exercise the production single-pane composition and include the Agents launch task profile cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: correct docked details top coordinate Use the editor title height directly for the absolutely positioned details pane and assert both its containing-block offset and visual border-box alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agentHost: fix /fleet turn ownership after Plan → Interactive
Running `/fleet` immediately after switching from Plan to Interactive left
the agent stuck ("plan approval declined twice", clarification UI "No active
turn"). Two compounding lifecycle defects in CopilotAgentSession caused it:
- RC1: the effective SDK agent mode was applied only after runtime
slash-command invocation, and the non-`agent-prompt` early return skipped
it entirely, so `/fleet` executed under a stale Plan mode.
- RC2: `/fleet` starts an asynchronous SDK agent loop but `commands.invoke`
returns a synchronous `completed` result, so the AHP turn was completed and
cleared ~100ms in, orphaning fleet's plan review, ask_user, tool calls, and
final output.
Fix (VS Code-only, temporary until the SDK returns `agent-prompt` for
`/fleet`):
- Apply the effective mode before invoking any non-skill runtime command,
retaining the later application for `agent-prompt` overrides.
- Route canonical built-in `/fleet` through the dedicated `rpc.fleet.start`
RPC and keep the AHP turn alive until `session.idle`. Reject attachments,
run the shared best-effort preflight (mode/permission/sandbox/MCP), and
guard aborts during preflight and racing the RPC so no orphaned loop or
duplicate terminal action can occur.
Refs microsoft/vscode-internalbacklog#8837
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* agentHost: capture /fleet abort token before slash-command resolution
An abort during `resolveSlashCommand` (which awaits `rpc.commands.list`)
drives a terminal `session.idle` that resets the live abort token and leaves
the pending turn open. `_startFleet` then captured `this._abortToken` after
that await, observing the fresh (uncancelled) token and starting an autonomous
fleet loop after the user cancelled — the turn-identity guard cannot catch it
because the pending turn is deliberately left open for the queued-message case.
Capture the turn's abort token at the top of `_send`, before any dispatch
await, and thread it into `_startFleet` so its guards honor an abort that raced
slash-command resolution (discarding the turn instead of starting the loop).
Add a regression test that fires the abort from an `rpc.commands.list` seam
(before the token capture) and asserts no fleet loop starts and no turn remains.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix single-tab close others enablement Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
* tunnels: fix: preserve reconnect pause reasons Fixes #331102 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a940617-0dcd-4977-ac27-8078a8937524 * tunnels: fix: honor pauses during discovery Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a940617-0dcd-4977-ac27-8078a8937524 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a940617-0dcd-4977-ac27-8078a8937524
* sessions: open pull requests in GitHub extension Use the GitHub Pull Requests URI handler when available, retain the external browser fallback, and keep PR editors free of docked Details. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: open issues in GitHub extension Use the GitHub Pull Requests issue URI handler when available and treat issue overview editors as self-contained in the single-pane layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: reuse pull request opening action Preserve explicit cross-repository pull request identities and route the Changes toolbar through the shared GitHub-aware action. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ed (#331458) Disable feedback dropdown for empty input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* change delay to 12 hrs by default * feedback * update policy
style(paneHeaders): refine header border and separator styles for modern UI Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
style: update tab hover styles and add test for tab action fading Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Allow all configured notice generation retries to complete before the task times out. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b641365-3b26-4e50-864d-d8f4fd22126a
* Update distro commit to 5475972d * chore: trigger CI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: vs-code-engineering[bot] <122617954+vs-code-engineering[bot]@users.noreply.github.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Dmitriy Vasyura <dmitriv@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enhance notification center styling by adjusting border-radius for the last row Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )