[pull] main from microsoft:main - #1612
Merged
Merged
Conversation
Keep the five-second timeout for client tool calls that this client owns. Do not cancel or deny user input, authentication, or confirmation requests that another client can claim. - Return before creating client-tool lifecycle state for requests from other clients. - Update request-timeout tests to verify unassigned requests remain pending. (Commit message generated by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Probe the optional origin/HEAD symbolic ref in quiet mode so repositories without it do not produce recurring agent host warnings. Add an integration test covering the expected missing-ref case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…31719) * agentHost: cover GraphQL mutation roots and null merge permission The mutation fix had no regression coverage: the existing tests only match operation names and variables, so reintroducing the invalid root-level rateLimit selection still passed. That is why the bug survived. ProgrammableGitHubServer now rejects any mutation that selects a Query-root-only field at the mutation root. Placing the check in the fake server rather than in individual assertions means every current and future mutation test enforces it automatically. Verified by reintroducing the bug, which now fails two tests with a direct diagnostic. The permission test also only covered a READ viewer. It now snapshots the whole RepositoryPermission range including null, the GitHub App case that deliberately disables Agent Merge, so the fail-closed path cannot regress on its own. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: resolve the selected operation in the GraphQL mutation guard The mutation-root guard only recognized documents whose first token was mutation, so a leading fragment definition or a multi-operation document bypassed it entirely. It also scanned every top-level selection set, so a sibling query selecting rateLimit failed an otherwise valid mutation. The guard now parses the document into operations, resolves the one selected by operationName (or the sole operation when the document is unambiguous), and inspects only that operation's root selection set. Parsing blanks comments and string literals first so braces inside them cannot skew matching, and skips variable definitions and inline fragment headers. ProgrammableGitHubServer tests now cover both regressions plus aliases, nested selections and string arguments. Verified they fail against the previous implementation in both directions: the fragment-prefixed mutation goes undetected, and the valid mutation beside a rateLimit query is wrongly rejected. The permission test folded its discriminant check into the recorded value, so a non-mergeability result collapsed to false and silently matched the TRIAGE, READ and null cases. It now asserts the fragment before snapshotting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agentHost: address session catalog review feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agent Host changes for benibenj/agents/vscode-insiders-agent-logs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )