[pull] main from chakra-ui:main - #296
Merged
Merged
Conversation
#3980) * fix(react): unwrap react.lazy asChild children across the RSC boundary React's Flight protocol hands children across the server components boundary wrapped in Symbol(react.lazy), which isValidElement rejects. The factory bailed out and rendered neither the child nor the element it stood in for. Unwrap the lazy child with Children.toArray, gated on the lazy symbol so every non-RSC path keeps its existing behavior. Matches the approach used by Base UI; Radix solves the same bug via use(). Verified end-to-end against a Next.js 15 production build: an async server component passed through asChild prerendered <main></main> before, and now renders the child with className and data attributes merged. Refs react/react#32392 Claude-Session: https://claude.ai/code/session_0133qcH6rpUR3edEeGJSxsF1 * test(react): cover ref composition through a react.lazy asChild child The factory resolves the lazy child before reading its ref and before merging props, so refs on a child that crossed the RSC boundary still attach. Nothing covered that ordering. Reading the ref or props off the un-unwrapped wrapper fails this test plus the two existing lazy tests, while the nine non-lazy tests keep passing. Claude-Session: https://claude.ai/code/session_0133qcH6rpUR3edEeGJSxsF1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )