[pull] main from withastro:main - #681
Merged
Merged
Conversation
…17611) * fix(dev): collect fresh CSS in fallback environments * add changeset * improvements * fix tests
…#17659) The fonts plugin embeds the ephemeral HTTP server's AddressInfo (including an OS-assigned port) into the font-file-url-resolver virtual module. Since the port changes every build, the incremental build plugin's dependency hash was non-deterministic, silently defeating all caching for any route that imports <Font />. Fix: assign the address to a variable named with a known token (__ASTRO_FONTS_SERVER_ADDRESS__) and have the incremental plugin strip the variable declaration before hashing, following the same pattern as resolveAssetPlaceholders for volatile asset emit handles. Fixes #17626 Co-authored-by: Matthew Phillips <matthew@matthewphillips.info> Co-authored-by: Emanuele Stoppa <estoppa@cloudflare.com>
…ency limiting and retry (#17650) Add a concurrency-limited file reader (`readFileWithRetry`) to `emitImageMetadata` that caps concurrent `fs.readFile` calls to 200 and retries transient OS errors (EMFILE, ENFILE, EAGAIN, EBUSY) with exponential backoff. The bare `catch` block that previously swallowed all errors now only returns `undefined` for ENOENT (file not found), re-throwing other errors with the real OS message instead of the misleading "Could not find requested image... Does it exist?" Fixes #17649
…d images during incremental builds (#17634)
Co-authored-by: tianrking <tianrking@users.noreply.github.com>
* fix: detect stale dev server lock files when the recorded PID was reused The lock file liveness check relied on process.kill(pid, 0), which only proves that some process owns the PID. After a Docker container restart the PID is quickly reused by an unrelated process while the lock file persists on the volume mount, so astro refused to start. The lock file now records the kernel start time from /proc/<pid>/stat alongside the PID, and the check verifies both. Lock files written by older versions are only treated as stale when the recorded process clearly started after the lock file was written (5s margin for soft clocks). Platforms without /proc keep the previous PID-existence check. Closes #17656 * fix: verify lock file process identity across platforms --------- Co-authored-by: Matthew Phillips <matthewphillips@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )