[pull] main from withastro:main - #690
Merged
Merged
Conversation
Follows the code review switch in #17725. Triage now runs in the factory Worker instead of `withastro/triagebot-action`, so `.github/workflows/issue-triage.yml` goes away — it was the only place the action was used. The triage config keeps the behaviour the action was configured with: the repository's own `.agents/skills/triage`, Opus for the pipeline and Sonnet for the fix-verification and re-triage classifiers, and no auto-PR, so a fix still waits for the reporter to confirm a preview release before a pull request is opened. The triage state labels are unchanged, so `issue-needs-repro.yml` and `.github/scripts/stale-issues.ts` keep working. Two things the action did in its own CI steps now have to be configured, because the factory hands the agent a bare checkout: - `installCommand` / `buildCommand` install and build the workspace. Without them a reproduction project resolves `astro` to `packages/astro/dist` and nothing runs, so the agent would report "could not reproduce" about its own unbuilt checkout. The install also clones the compiler for the diagnose and verify steps to read, non-fatally since it is reference-only. - `factory-preview.yml` publishes preview releases. The factory can't publish them itself — pkg.pr.new authenticates with this repository's Actions OIDC identity, which a Worker can't present — so it dispatches this workflow on the default branch and reads the published package list back from a check run. Publishing and reporting are separate jobs so the one that runs fix-branch code holds neither repository secrets nor `checks: write`. The Anthropic API key now lives on the Worker, so the `CI_ANTHROPIC_API_KEY` repository secret is no longer used by anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )