Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-computed-decorator.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx": minor
---

feat(mobx): make the 2022.3 `@computed` decorator lazy. `ComputedValue` is now created on first read of the decorated getter rather than eagerly during instance construction, avoiding wasted allocations for getters that are never used. On a 50k-instance × 10-getter class with one read per instance this cuts construction heap by ~50% and construction time by ~25%; the steady-state read path is unchanged. Closes #4616.
5 changes: 5 additions & 0 deletions .changeset/npm-workspace-cli-resolution.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx-undecorate": patch
---

Fix CLI resolution of the bundled jscodeshift binary when dependencies are hoisted by npm workspaces.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

- [ ] Added/updated unit tests
- [ ] Updated `/docs`. For new functionality, at least `API.md` should be updated
- [ ] Verified that there is no significant performance drop (`yarn mobx test:performance`)
- [ ] Verified that there is no significant performance drop (`npm -w mobx run test:performance`)

<!--
Feel free to ask help with any of these boxes!
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,25 @@ jobs:
node-version: 24

- name: Install Dependencies
run: yarn --frozen-lockfile --ignore-scripts
run: npm ci --ignore-scripts

- name: Lint
run: yarn lint
run: npm run lint

- name: Build check
run: yarn lerna run build:check
run: npm run build:check

- name: Build packages
run: yarn lerna run build:test
run: npm run build:test

- name: Test
run: yarn test -i
run: npm test -- -i

- name: Test size
run: yarn lerna run test:size
run: npm run test:size

- name: Test flow
run: yarn mobx test:flow
run: npm -w mobx run test:flow

- name: Test performance
run: yarn mobx test:performance
run: npm -w mobx run test:performance
6 changes: 3 additions & 3 deletions .github/workflows/coveralls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
node-version: 24

- name: Install Dependencies
run: yarn --frozen-lockfile --ignore-scripts
run: npm ci --ignore-scripts

- name: Build packages
run: yarn lerna run build:test
run: npm run build:test

# - name: Run Coverage
# run: yarn coverage
# run: npm run coverage

# - name: Upload to coveralls
# uses: coverallsapp/github-action@v2.3.6
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
registry-url: https://registry.npmjs.org

- name: Install Dependencies
run: yarn
run: npm ci --ignore-scripts

- name: Build packages
run: yarn lerna run build
run: npm run build

- name: Create Release Pull Request or Publish to npm
id: changesets
Expand All @@ -44,4 +44,3 @@ jobs:
publish: npm run release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ dist/
*.iml
*.ipr
*.iws
yarn-error.log
build/
.DS_Store
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@ For a small bug fix change (less than 20 lines of code changed), feel free to op

#### Getting things running

Use Node.js 24, matching CI. The npm version bundled with Node is sufficient.

```
git clone git@github.com:mobxjs/mobx.git
cd mobx
yarn install
yarn lerna run build
yarn test
npm install
npm run build
npm test
```

6 changes: 0 additions & 6 deletions lerna.json

This file was deleted.

Loading