[pull] canary from vercel:canary - #1312
Merged
Merged
Conversation
…#95975) ## What The persistence-layer mechanism to tombstone (delete) tasks from the on-disk cache. A GC-collected task is represented as a `SnapshotItem::Delete` that rides the same streaming iterator `save_snapshot` already consumes for puts, so tombstones are applied in the same commit/batch as the snapshot with no side-channel. - `SnapshotItem` becomes an enum: `Put { … }` (the existing path) and `Delete(TaskDeletion)`. - `TurboWriteBatch::delete/value_delete` passthrough to `turbo_persistence`. - `save_snapshot` applies deletes inline in the parallel put phase ## Note `SnapshotItem::Delete` is `#[allow(dead_code)]` here: this PR lands the persistence-side *handling* and its tests, but nothing *emits* a `Delete` yet. The GC pass that soft-deletes tasks and serializes them to `Delete` lands in the next PR in the stack. So this PR is a no-op at runtime. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…6043) Change the semantics of `task` so that it enforces that tasks actually exist (either in memory or storage). For the rare cases we expect to be creating tasks, have callers call `get_or_create_task` generally creating a task is _racy_ so it is always `get_or_create` but when doing things like updating the aggregation graph or reading cells, we _know_ it must exist so assert it. Currently this is a `debug_assert` but with the GC we may update it to a full assert. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )