[pull] canary from vercel:canary - #1313
Merged
Merged
Conversation
## Summary - Use the job-scoped `GITHUB_TOKEN` with explicit `actions: write` permission to dispatch `trigger_release.yml` after a stable backport. - Avoid requesting Actions write access from the release GitHub App, which currently prevents the dispatch token from being created. - Preserve the existing forced preminor canary release behavior. This fixes the failure that left canary semver-behind stable after the `v16.3.1` backport. The evaluation succeeded, but the dispatch failed while creating the App token in the [failing dispatch job](https://github.com/vercel/next.js/actions/runs/31750536217/job/94615208366). ## Verification https://github.com/vercel/next.js/actions/runs/31830288265/job/94864091005 ``` should_dispatch=true reason=Dispatching canary preminor release because stable release 16.3.1 is ahead of 16.3.1-canary.17 released_version=16.3.1 current_canary_version=16.3.1-canary.17 dispatch_input=false auto_dispatch_enabled=true ```
### What? Restores the missing `node_modules` fixtures for the `exports`, `exports-fallback`, `exports-only` and `exports-path` cases in `turbopack-tracing`'s NFT unit test suite (`tests/unit.rs`), and enables the two that pass as-is (`exports-only`, `exports-path`). Co-authored-by: vercel-fleet[bot] <308483924+vercel-fleet[bot]@users.noreply.github.com>
### What? Change the pointer-width assertion in `usize_from_u32` from `<` to `<=`, allowing the conversion to compile on 32-bit targets. ### Why? The surrounding comment states that Turbopack assumes a pointer width of at least 32 bits, but the strict comparison rejects exactly 32-bit targets. Since `u32` and `usize` have the same width on these targets, the conversion remains lossless. This currently causes `rspack-turbo-persistence` to fail to compile with `error[E0080]` in Rspack's [`i686-pc-windows-msvc` CI job](https://github.com/web-infra-dev/rspack/actions/runs/31665978273/job/94340544786#step:25:446). ### How? Allow equal source and target bit widths in the compile-time assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )