[pull] canary from vercel:canary - #1315
Merged
Merged
Conversation
Recreation of #96910 ### What? Adds a test for i18n basepath fallbacks. ### Why? We had this test in `vercel/vercel`: https://github.com/vercel/vercel/blob/main/packages/next/test/fixtures/00-i18n-basepath-fallback-false-404/index.test.js We're getting rid of it in favor of moving it to here in Next.js. This new test is meant to be equivalent to the original. Co-authored-by: Anthony Shew <anthonyshew@gmail.com>
These tests were timing out because they are suddenly waiting for a very long DNS timeout - https://github.com/vercel/next.js/actions/runs/32116429187/job/95655640990?pr=90300 - https://github.com/vercel/next.js/actions/runs/32116429187/job/95655640961?pr=90300
- Adding docs/01-app/03-api-reference/05-config/01-next-config-js/cacheMaxMemorySize.mdx - Various use cache snippet fixes - Break nuance for fetch default - Point to correct turbopack cache flags
In #80281 we moved the README from `../../packages/next/src/client/components/react-dev-overlay/README.md` to `packages/next/src/next-devtools/README.md`, but did not update the link in the contributing guide.
… tests (#97460) Co-authored-by: Claude Code (kimi-k3[1m]) <noreply@anthropic.com>
### What? Adds a public OpenTelemetry span for the cold evaluation of an App Route's lazy userland module: - span type: `AppRouteRouteModule.loadUserland` - display name: `load app route module` - route-specific attribute: the normalized `next.route` pattern ### Why? `LoadComponents.loadRouteModule` measures loading Next.js's compiled route entry. App Routes then defer the actual userland module behind a `LazyModule`, so expensive top-level module evaluation can occur after that existing span has ended and remain invisible in traces. ### How? The App Route module wraps only its lazy userland factory with the Next.js tracer. `LazyModule` still memoizes that factory, so each route-module instance emits one span for its successful cold initialization and warm requests reuse the initialized value. The HMR getter remains untraced, and the span records no resolved filename or request URL. The integration fixture uses top-level await to exercise the asynchronous module path. Coverage verifies the span is a descendant of the request, appears exactly once across cold and warm requests, and works with the direct entrypoint handler. ### Verification - `pnpm exec jest packages/next/src/server/lib/trace/tracer.test.ts --runInBand` - `HEADLESS=true pnpm test-dev-turbo test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts -t 'should trace cold App Route module loading'` - `HEADLESS=true pnpm test-dev-webpack test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts -t 'should trace cold App Route module loading'` - `HEADLESS=true pnpm test-start-turbo test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts -t 'should trace cold App Route module loading'` - `HEADLESS=true pnpm test-start-webpack test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts -t 'should trace cold App Route module loading'` - Exact-head GitHub build-and-test run `31950299347`: 102/102 jobs passed. - Exact-head Generate Stats run `31950299340`: passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )