[pull] main from microsoft:main - #798
Merged
Merged
Conversation
the TS overloads make it so that `options` is only set when `optionsOrEndpoint` is a string otherwise, `optionsOrEndpoint` is the options object
`_handleRequest` already records every request (and `_handleResponse` does not re-add it)
…lls (#41480) `pollAgainstDeadline` mutates the provided `pollIntervals` both `expect.poll` and `expect.toPass` pass it by reference the former uses a per-test config, whereas the latter uses a per-project config that's shared by every test (in that worker)
… or `/.../y` (#41470) global `/.../g` and sticky `/.../y` regular expressions silently adjust `lastIndex` this means that subsequent uses will miss any matches before the new `lastIndex` (until it wraps around) as such, we should reset the `lastIndex` before trying to use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )