Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
},
{
"name": "webkit",
"revision": "2325",
"revision": "2327",
"installByDefault": true,
"revisionOverrides": {
"mac14": "2251",
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/webkit/protocol.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6372,7 +6372,7 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
/**
* List of settings able to be overridden by WebInspector.
*/
export type Setting = "PrivateClickMeasurementDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebSecurityEnabled"|"DeviceOrientationEventEnabled"|"SpeechRecognitionEnabled"|"PointerLockEnabled"|"NotificationsEnabled"|"FullScreenEnabled"|"InputTypeMonthEnabled"|"InputTypeWeekEnabled"|"FixedBackgroundsPaintRelativeToDocument";
export type Setting = "PrivateClickMeasurementDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebSecurityEnabled"|"DeviceOrientationEventEnabled"|"SpeechRecognitionEnabled"|"PointerLockEnabled"|"NotificationsEnabled"|"FullScreenEnabled"|"InputTypeMonthEnabled"|"InputTypeWeekEnabled"|"FixedBackgroundsPaintRelativeToDocument"|"PushAPIEnabled";
/**
* A user preference that can be overriden by Web Inspector, like an accessibility preference.
*/
Expand Down
1 change: 1 addition & 0 deletions packages/playwright-core/src/tools/mcp/browserFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ async function createCDPBrowser(config: FullConfig, clientInfo: ClientInfo): Pro
const browser = await playwright.chromium.connectOverCDP(config.browser.cdpEndpoint!, {
headers: config.browser.cdpHeaders,
timeout: config.browser.cdpTimeout,
noDefaults: true,
artifactsDir,
});
return browser;
Expand Down
12 changes: 9 additions & 3 deletions tests/library/browsercontext-cookies-third-party.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,13 @@ test(`add 'Partitioned;' cookie via API`, async ({ page, context, browserName, h
{
// Check top-level cookie first.
await page.goto(urls.read_origin1);
const expectedTopLevel = (browserName === 'webkit' && !webkitPartitions) || (browserName === 'firefox' && !isBidi) ?
'Received cookie: frame-non-partitioned=value; frame-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value' :
'Received cookie: frame-non-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value';
let expectedTopLevel: string;
if (browserName === 'webkit' && isMac && !webkitPartitions)
expectedTopLevel = 'Received cookie: frame-non-partitioned=value; top-level-non-partitioned=value';
else if ((browserName === 'webkit' && !webkitPartitions) || (browserName === 'firefox' && !isBidi))
expectedTopLevel = 'Received cookie: frame-non-partitioned=value; frame-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value';
else
expectedTopLevel = 'Received cookie: frame-non-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value';
expect.soft(await page.locator('body').textContent()).toBe(expectedTopLevel);
}
{
Expand All @@ -409,6 +413,8 @@ test(`add 'Partitioned;' cookie via API`, async ({ page, context, browserName, h
let expectedThirdParty = 'Received cookie: ';
if (webkitPartitions)
expectedThirdParty += 'frame-non-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value';
else if (browserName === 'webkit' && isMac)
expectedThirdParty += 'frame-non-partitioned=value; top-level-non-partitioned=value';
else if (browserName === 'webkit' || (browserName === 'firefox' && !isBidi))
expectedThirdParty += 'frame-non-partitioned=value; frame-partitioned=value; top-level-non-partitioned=value; top-level-partitioned=value';
else if (browserName === 'firefox' && isBidi)
Expand Down
2 changes: 0 additions & 2 deletions tests/library/modernizr.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ it('Safari Desktop', async ({ browser, browserName, platform, httpsServer, chann

expected.pushmanager = false;
expected.devicemotion2 = false;
expected.devicemotion = false;
expected.deviceorientation = false;
expected.deviceorientation3 = false;

delete expected.webglextensions;
Expand Down
13 changes: 13 additions & 0 deletions tests/mcp/cdp.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ test('cdp server reuse tab', async ({ cdpServer, startClient, server }) => {
});
});

test('cdp connection uses noDefaults', async ({ cdpServer, startClient }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41661' });
const browserContext = await cdpServer.start();
const [page] = browserContext.pages();
await page.emulateMedia({ media: 'print' });
expect(await page.evaluate(() => matchMedia('print').matches)).toBe(true);

const { client } = await startClient({ args: [`--cdp-endpoint=${cdpServer.endpoint}`] });
await client.callTool({ name: 'browser_snapshot' });

expect(await page.evaluate(() => matchMedia('print').matches)).toBe(true);
});

test('should throw connection error and allow re-connecting', async ({ cdpServer, startClient, server }) => {
const { client } = await startClient({ args: [`--cdp-endpoint=${cdpServer.endpoint}`] });

Expand Down
Loading