[pull] main from microsoft:main

packages/playwright-core/src/server/chromium/crExecutionContext.ts

@@ -104,6 +104,8 @@ function rewriteError(error: Error): Protocol.Runtime.evaluateReturnValue {
     throw new Error('Cannot serialize result: object reference chain is too long.');
   if (error.message.includes('Object couldn\'t be returned by value'))
     return { result: { type: 'undefined' } };
+  if (error.message.includes('Promise was collected'))
+    throw new Error('Resulting promise was garbage collected.');
 
   if (error instanceof TypeError && error.message.startsWith('Converting circular structure to JSON'))
     rewriteErrorMessage(error, error.message + ' Are you passing a nested JSHandle?');

tests/library/defaultbrowsercontext-2.spec.ts

@@ -20,7 +20,6 @@ import fs from 'fs';
 import path from 'path';
 
 it.skip(({ mode }) => mode !== 'default', 'Remote persistent contexts are not supported');
-it.slow(({ browserName, isMac }) => browserName === 'firefox' && isMac && process.arch === 'x64', 'Persistent Firefox launches are slow on Intel macOS runners under load.');
 
 it('should support hasTouch option', async ({ server, launchPersistent }) => {
   const { page } = await launchPersistent({ hasTouch: true });
@@ -148,7 +147,6 @@ it('should goto about:blank on relaunched persistent context', {
   annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' },
 }, async ({ browserType, createUserDataDir, browserName, isBidi }) => {
   it.fixme(browserName === 'firefox' && !isBidi);
-  it.slow();
 
   const userDataDir = await createUserDataDir();
 

tests/library/playwright.config.ts

@@ -61,7 +61,7 @@ const config: Config<PlaywrightWorkerOptions & PlaywrightTestOptions & TestModeW
     timeout: 10000,
   },
   maxFailures: 200,
-  timeout: video ? 60000 : 30000,
+  timeout: video || (process.platform === 'darwin' && process.arch === 'x64') ? 60000 : 30000,
   globalTimeout: 7200000,
   workers: undefined,
   fullyParallel: !process.env.CI,

tests/library/screencast.spec.ts

@@ -205,7 +205,6 @@ test('start should finish when page is closed', async ({ browser }, testInfo) =>
 });
 
 test('empty video', async ({ browser }, testInfo) => {
-  test.slow();
   const size = { width: 800, height: 800 };
   const context = await browser.newContext({ viewport: size });
   const page = await context.newPage();

tests/mcp/annotate.spec.ts

@@ -228,7 +228,6 @@ test('user-initiated annotate downloads zip with feedback.md', async ({ connectT
 });
 
 test('should capture annotations via show --annotate', async ({ connectToDashboard, cli, server }) => {
-  test.slow();
   await cli('open', server.EMPTY_PAGE);
   const bindTitle = `--playwright-internal--${crypto.randomUUID()}`;
   await cli('show', { bindTitle });
@@ -495,7 +494,6 @@ test('should switch screencast to -s session on show --annotate', async ({ conne
 });
 
 test('should disengage annotate mode when --annotate client disconnects', async ({ connectToDashboard, cli, childProcess, cliEnv, mcpBrowser, mcpHeadless, server }) => {
-  test.slow();
   await cli('open', server.EMPTY_PAGE);
   const bindTitle = `--playwright-internal--${crypto.randomUUID()}`;
   await cli('show', { bindTitle });

tests/mcp/test-run.spec.ts

@@ -124,7 +124,6 @@ Running 2 tests using 1 worker
 });
 
 test('test_run should stop when aborted', async ({ startClient }) => {
-  test.slow(true, 'Drives two full test-runner lifecycles (abort + restart)');
   await writeFiles({
     'slow.test.ts': `
       import { test } from '@playwright/test';

tests/page/page-evaluate.spec.ts

@@ -889,3 +889,13 @@ it('should ignore dangerous object keys', async ({ page }) => {
   const result = await page.evaluate(arg => arg, input);
   expect(result).toEqual({ safeKey: 'safeValue' });
 });
+
+it('promise collected', async ({ page, browserName }) => {
+  it.skip(browserName !== 'chromium', 'this is a chromium-only behavior');
+
+  const resultPromise = page.evaluate(() => new Promise<void>(() => {})).catch(e => e);
+  for (let i = 0; i < 20; i++)
+    await page.requestGC();
+  const error = await resultPromise;
+  expect(error.message).toContain('Resulting promise was garbage collected');
+});