Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 0 additions & 81 deletions .github/workflows/roll_browser_into_playwright.yml

This file was deleted.

2 changes: 0 additions & 2 deletions packages/playwright-core/src/server/bidi/bidiBrowser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,6 @@ export class BidiBrowserContext extends BrowserContext {
await Promise.all(promises);
}

onClosePersistent() {}

override async clearCache(): Promise<void> {
}

Expand Down
3 changes: 0 additions & 3 deletions packages/playwright-core/src/server/browserContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,6 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdk
this._closedStatus = 'closed';
this._clientCertificatesProxy?.close().catch(() => {});
this.tracing.abort();
if (this._isPersistentContext)
this.onClosePersistent();
this._closePromiseFulfill!(new Error('Context closed'));
this.emit(BrowserContext.Events.Close);
}
Expand Down Expand Up @@ -303,7 +301,6 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdk
protected abstract doUpdateDefaultEmulatedMedia(): Promise<void>;
protected abstract doExposePlaywrightBinding(): Promise<void>;
protected abstract doClose(reason: string | undefined): Promise<void | 'close-browser'>;
protected abstract onClosePersistent(): void;

async cookies(progress: Progress, urls: string | string[] | undefined = []): Promise<channels.NetworkCookie[]> {
return await progress.race(this._cookies(urls));
Expand Down
3 changes: 0 additions & 3 deletions packages/playwright-core/src/server/chromium/crBrowser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -576,9 +576,6 @@ export class CRBrowserContext extends BrowserContext<CREventsMap> {
}
}

onClosePersistent() {
}

override async clearCache(): Promise<void> {
for (const page of this._crPages())
await page._networkManager.clearCache();
Expand Down
2 changes: 0 additions & 2 deletions packages/playwright-core/src/server/firefox/ffBrowser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,6 @@ export class FFBrowserContext extends BrowserContext {
this._browser.session.send('Browser.addBinding', { browserContextId: this._browserContextId, name: PageBinding.kBindingName, script: '' });
}

onClosePersistent() {}

override async clearCache(): Promise<void> {
// Clearing only the context cache does not work: https://bugzilla.mozilla.org/show_bug.cgi?id=1819147
await this._browser.session.send('Browser.clearCache');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ export class WVBrowserContext extends BrowserContext {
await (page.delegate as WVPage).exposePlaywrightBinding();
}

override async onClosePersistent() {}
override async doUpdateDefaultViewport() {}
override async doUpdateDefaultEmulatedMedia() {}
override async clearCache(): Promise<void> { throw new Error('Method not implemented.'); }
Expand Down
2 changes: 0 additions & 2 deletions packages/playwright-core/src/server/webkit/wkBrowser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ export class WKBrowserContext extends BrowserContext {
await (page.delegate as WKPage).exposePlaywrightBinding();
}

onClosePersistent() {}

override async clearCache(): Promise<void> {
// We use ephemeral contexts so there is no disk cache.
await this._browser._browserSession.send('Playwright.clearMemoryCache', {
Expand Down
3 changes: 2 additions & 1 deletion utils/build/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ async function runWatch() {
for (const { files, from, to, ignored } of copyFiles) {
const watcher = chokidar.watch([filePath(files)], { ignored });
watcher.on('all', (event, file) => {
copyFile(file, from, to);
if (event === 'add' || event === 'change')
copyFile(file, from, to);
});
}

Expand Down
Loading