Skip to content

[pull] main from microsoft:main #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jul 22, 2026
Merged

[pull] main from microsoft:main #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/injected/src/roleUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ const kImplicitRoleByTagName: { [tagName: string]: (e: Element) => AriaRole | nu
'IMG': (e: Element) => (e.getAttribute('alt') === '') && !e.getAttribute('title') && !hasGlobalAriaAttribute(e) && !hasTabIndex(e) ? 'presentation' : 'img',
'INPUT': (e: Element) => {
const type = (e as HTMLInputElement).type.toLowerCase();
if (type === 'search')
return e.hasAttribute('list') ? 'combobox' : 'searchbox';
if (['email', 'tel', 'text', 'url', ''].includes(type)) {
if (['email', 'search', 'tel', 'text', 'url', ''].includes(type)) {
// https://html.spec.whatwg.org/multipage/input.html#concept-input-list
const list = getIdRefs(e, e.getAttribute('list'))[0];
return (list && elementSafeTagName(list) === 'DATALIST') ? 'combobox' : 'textbox';
if (list && elementSafeTagName(list) === 'DATALIST')
return 'combobox';
return type === 'search' ? 'searchbox' : 'textbox';
}
if (type === 'hidden')
return null;
Expand Down
15 changes: 15 additions & 0 deletions tests/library/role-utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,21 @@ test('native controls', async ({ page }) => {
expect.soft(await getNameAndRole(page, '#file2')).toEqual({ role: 'button', name: 'FILE2' });
});

test('input type=search maps to searchbox unless list points at a datalist', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41899' },
}, async ({ page }) => {
await page.setContent(`
<input id="search1" type=search>
<input id="search2" type=search list=nope>
<input id="search3" type=search list=dv><div id=dv></div>
<input id="search4" type=search list=dl><datalist id=dl></datalist>
`);
expect.soft(await getNameAndRole(page, '#search1')).toEqual({ role: 'searchbox', name: '' });
expect.soft(await getNameAndRole(page, '#search2')).toEqual({ role: 'searchbox', name: '' });
expect.soft(await getNameAndRole(page, '#search3')).toEqual({ role: 'searchbox', name: '' });
expect.soft(await getNameAndRole(page, '#search4')).toEqual({ role: 'combobox', name: '' });
});

test('native controls labelled-by', async ({ page }) => {
await page.setContent(`
<label id="for-text1">TEXT1</label><input aria-labelledby="for-text1" id="text1" type=text>
Expand Down
Loading