[pull] main from remix-run:main - #301
Merged
Merged
Conversation
Assisted-By: devx/05e5feb4-b90f-4cee-89aa-86f527ec65a5
Assisted-By: devx/05e5feb4-b90f-4cee-89aa-86f527ec65a5
Assisted-By: devx/05e5feb4-b90f-4cee-89aa-86f527ec65a5
…ord.gg/reactrouter (#15215) * docs: replace dead https://rmx.as/discord shortlink with https://discord.gg/reactrouter The `rmx.as` shortlink server returns HTTP 526 (Cloudflare origin unreachable), so users following the Discord link from any of these locations end up on a Cloudflare error page instead of the React Router community Discord: - docs/upgrading/router-provider.md - docs/upgrading/component-routes.md - scripts/pr.ts (PR template body) - packages/create-react-router/index.ts (CLI output on `create-react-router`) - .github/workflows/issue-checks.yml (issue-close & stale-bot messages, x2) - .github/ISSUE_TEMPLATE/config.yml (issue template 'Get help' link) The replacement `https://discord.gg/reactrouter` is the canonical Discord invite slug (301 → discord.com/invite/reactrouter, returns 200). Same target Discord server, just a working URL. Verified the new URL: $ curl -sIL https://discord.gg/reactrouter | head -2 HTTP/2 301 location: https://discord.com/invite/reactrouter $ curl -sIL https://discord.com/invite/reactrouter | head -1 HTTP/2 200 And the broken URL: $ curl -sIL https://rmx.as/discord | head -1 HTTP/2 526 * docs: use canonical discord.gg/xwx7mMzVkA invite + sign CLA - Replace discord.gg/reactrouter with discord.gg/xwx7mMzVkA across 6 files. This is the canonical Remix/React Router Discord invite per the rmx.as shortener's _redirects config (the destination that the shortener was always supposed to redirect to). Uses the same invite code as the shortener's intended target rather than a different one. - Sign CLA by adding @sanjibani to contributors.yml (alphabetical, between sanjai451 and sanketshah19). Addresses maintainer @MichaelDeBoey's feedback on #15215 about which Discord invite is canonical. The rmx.as shortener itself is still returning HTTP 526 (Cloudflare origin unreachable, Netlify deployment unreachable) — that's an infra issue separate from this PR. * Apply suggestions from code review Co-authored-by: Matt Brophy <matt@brophy.org> * Update .github/ISSUE_TEMPLATE/config.yml --------- Co-authored-by: sanjibani <18418553+sanjibani@users.noreply.github.com> Co-authored-by: Matt Brophy <matt@brophy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )