[pull] main from remix-run:main - #318
Merged
Merged
Conversation
…er crash (#15286) When a client aborts a document request, the readable side of the injectRSCPayload TransformStream is cancelled while a buffered flush (setTimeout(..., 0)) may still be pending. The timer then enqueues into a cancelled stream, throwing "TypeError: Invalid state: Unable to enqueue" from a timer callback — an unhandled rejection that kills the server process. Add a cancel() handler that clears the pending flush, drops the buffer, and cancels the underlying RSC payload stream, plus cancellation guards on the flush timer and the RSC writer loop. Fixes #15275 * add a few more tests --------- Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )