[pull] main from remix-run:main - #339
Merged
Merged
Conversation
Assisted-By: devx/aaadeb35-56c3-489a-a810-9ba5c4bbf995
…ered (#15399) * fix: don't cache aborted lazy route discoveries as discovered fetchAndApplyManifestPatches mutated manifest.routes and added the path to the module-singleton discoveredPaths FIFO unconditionally once the /__manifest response body settled, while the router's patch callback no-ops when the triggering navigation/fetcher signal has aborted in the meantime. An abort landing in that window cached the path as "discovered" for the rest of the session while the route tree was never patched, so every subsequent visit matched an ambiguous route (e.g. a catch-all) instead of the real one - or 404ed when nothing matched. Only a hard reload cleared it. Bail out before any cache/manifest mutation when the signal has already aborted so the next visit to the path re-runs discovery. Fixes #15327 * chore: sign CLA --------- Co-authored-by: Matt Brophy <matt@brophy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )