[pull] main from adobe:main - #287
Merged
Merged
Conversation
* fix(focus): handle single radio button in FocusScope Fixes #9569 form.elements.namedItem() returns an Element (not RadioNodeList) when there is exactly one element with that name. This caused TypeError when trying to spread a non-iterable Element. The fix checks if namedItem() returns a single Element before spreading, handling all three possible return types per the DOM spec: - RadioNodeList (iterable) for 2+ elements with the same name - Element (NOT iterable) for exactly 1 element - null for no elements * Update packages/@react-aria/focus/src/FocusScope.tsx * Update packages/@react-aria/focus/src/FocusScope.tsx * Add getOwnerWindow import to FocusScope --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
…9615) * fix: correct aria-posinset to use 1-based index in virtualized Menu * Have Menu set isVirtualized automatically, add test and story --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
We have some form binding logic that depends on native form elements being inside the ref element. The current implementation of ComboBox breaks this design. This also makes it more difficult to access the native element for certain reasons (unless we add an extra div wrapper outside). I suggest changing the rendering structure of ComboBox to be consistent with Select, rendering the native form element inside the div instead of as a sibling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )