[pull] main from adobe:main - #364
Merged
Merged
Conversation
* feat: compatibility for modern icu * update node version so that we can have correct instructions in our contributing and the nvmrc will work if you have 2.14.1 or above installed already * Apply suggestions from code review Co-authored-by: Robert Snow <snowystinger@gmail.com> --------- Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
…idth (#9961) * fix: ensure virtualized Table loader width is updated if table width changes * fix weird scroll behavior when multiple pages loaded * typo
* feat: Support help text in Checkbox, Radio, and Switch * fix * Fix checkbox styling when nested in collections * A couple more tests * fix aria-describedby behavior * Add tests for CheckboxField in collections * Add help text support in S2 * updates from testing * lint * make radiogroup rac example also grey out help text when disabled * whoops forgot it for switch too --------- Co-authored-by: Daniel Lu <dl1644@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )