[pull] main from adobe:main - #413
Merged
Merged
Conversation
* prototype * Change over all useSelectableCollection to use the new shortcuts syntax * try making object more readable * share types * simplify and add tests, move to interactions. fix outstanding bug * fix react 16 tests * Starting converting everything to use shortcuts * fix all of the lint * fix: calendar tests * convert calendar and date picker * actiongroup and datesegment and lint * simplify code * fix lint * fix ts that I don't think i broke * add combobox * simplify some code * fix lint * Remove "Sel" expansion * change to void return * fix ts * update everything to the void signature * review comments * remove stale todo
…on input (#10156) useAutocomplete only called focusFirstItem() when inputType was 'insertText'. IME-based input (CJK languages) reports 'insertCompositionText'/'insertFromComposition' instead, which fell through to clearVirtualFocus(true), so the first matching item never received virtual focus and Enter could not select it. Closes #10126
* chore: update issue report template to mention Stackblitz * update wording * address review comments
…ith native-overlapping states (#9974) * fix(tailwindcss-react-aria-components): make not-* variants compose with native-overlapping states Tailwind's `not-*` compound walker bails when a variant produces more than one style rule per path. The dual-selector (array) shape used for variants that overlap native CSS states (hover, focus, disabled, invalid, etc.) emitted two sibling rules, so `not-disabled:`, `not-invalid:`, `not-focus:`, `not-hover:`, and similar utilities silently generated no CSS. Collapse both branches into a single `:is()` selector. `:where()` keeps specificity at (0,1,0) so cascade behavior matches the previous output. Hover additionally needs `@media (hover: hover)` to prevent sticky styles on touch devices. Emitting it as a CSS-in-JS object (instead of a string starting with `@media`) causes Tailwind to report the variant's compounds as `StyleRules | AtRules`, which preserves `group-hover:` / `peer-hover:` composition while still giving `not-hover:` the "1 style rule + 1 at-rule per path" shape the walker requires. Test coverage extended with `not-*`, `group-not-*`, `peer-not-*`, `has-not-*`, `not-group-*`, `peer-hover:`, and `in-*` variants. * format * cleanup --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )