[pull] main from adobe:main - #450
Merged
Merged
Conversation
…se-on-scroll fix (#10188) * fix: Virtualizer, useCloseOnScroll are able to work in the shadow DOM (#10093) * reduce scope of testing, add tests for helper, fix storybook behaviours * fix ts * getPropagationTargets `to` can be a non-global node * feat: lint rules for non-composing events on addEvent/addEventListener Add two rsp-rules ESLint rules to prevent shadow DOM regressions with non-composing events (scroll, scrollend, change, submit, reset, select, selectstart, slotchange), which do not cross shadow DOM boundaries: - add-event-non-composing: flags addEvent(target, 'scroll', ...) unless the target is getPropagationTargets(...). - no-non-composing-event-listener: flags x.addEventListener('scroll', ...) for non-composing events, exempting non-DOM-tree receivers (visualViewport, MediaQueryList). Both rules are enabled globally and disabled for non-shipping code (tests, stories, docs, chromatic, dev). Existing legitimate element-scoped listeners in useFormValidation, useFormReset, and Chat carry inline exemptions with explanations. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix imports not ultimately used * rename test --------- Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
…alog into view (#10339) * fix: restore focus without scrolling in FocusScope containment * fix: route containment restore through focusElement for owner-document scroll safety * create a test for the goal, not the implementation --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Rob Snow <rsnow@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )