[pull] main from adobe:main - #455
Merged
Merged
Conversation
* feat: S2 SideNav * hack a way for arrow key navigation to continue to work * working * move to new grid navigation behaviours * remove allowChildKeys hack, add code to get in front of navigation, change API, add tests * add a router to make it easier to test in the browser * add descendent selection styles, fix indicator no animation * Moves to new API selectedRoute, fixes double arrow key navigate to parent, fixes initial focus * remove comment * Add docs, exports, fix props, * make prop optional for now since it caused the docs to break * fix types * fix ts * fix click interaction on Categories and disabled items * Move to GridList handling, fix colors, add tests and chromatic * lots of cleanup * remove useless test and add chromatic to replace it * fix lint * fix required props, cleanup * add tests and fix lost focus case * restrict logic to tab keyboard nav * fix docs ts * review comments * fix label text wrapping * Fix keyboard navigation with sections * fix current selection bold * fix heights * add press scaling to items * fix lint * setup alpha and card * fix types * review comments * fix typo * and lint * fix docs ts * forgot to save * fingers crossed last one * make a router that looks like React Router, inert hidden text * fix types and inert * remove space reserving, it doesn't work --------- Co-authored-by: Daniel Lu <dl1644@gmail.com>
* do not clip loader * preserve prominent outline glow when generating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )