[pull] main from adobe:main - #471
Merged
Merged
Conversation
* fix: DialogTrigger inside Tabs Collection triggers render nothing inside another collection's hidden pass so the outer collection doesn't inherit items from the inner one. #10019 did this for MenuTrigger, Select and ComboBox, but DialogTrigger was missed, so a dialog containing collection content still renders detached during an ancestor collection's scan and throws — for example a Menu inside a popover dialog, which builds its items with a null selection manager. Mirrors the MenuTrigger fix. * Move the hidden check below the hooks Returning early between hooks made useRef, useOverlayTrigger and useId conditional. MenuTrigger runs all of its hooks before bailing; do the same here. * Update packages/react-aria-components/test/Tabs.test.js * Apply suggestion from @snowystinger fix lint --------- Co-authored-by: Rob Snow <snowystinger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )