[pull] main from adobe:main - #474
Merged
Merged
Conversation
#10424) julianDayToCE estimates the year assuming years average exactly 365.25 days, but year starts are placed at 365 * year + floor(year / 4) days after the epoch — up to 3/4 of a day earlier. On the first day of any year not divisible by 4 (3 of every 4 years), the estimate lands one year low, so New Year's Day is reported as the previous year's constrained last day (13-5) and gregorian round trips lose a day. Correct the estimate by comparing against the julian day of the start of the next year, as proposed in #10390. The estimate is never more than one year low and never high, so a single correction suffices, and it only fires on the exact year-start days that were previously wrong. Affects ethiopic, ethioaa and coptic, which share this function.
* example of rslib issues in React Spectrum * Commit a working rslib --------- Co-authored-by: Rob Snow <rsnow@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )