[pull] main from adobe:main - #477
Merged
Merged
Conversation
…update invalid styling for preview only (#10452) * support illustration in attachment and center when preview only * switch to only use Illustration * adjusting size of preview only illustration and reducing gapbetween illustration and text * handle preview only invalid better, in progress case with illustration, get rid of reliance on horizontal card * delete horizontal card stories * ignore codex config for scout * review updates * delete horizontal card
…Unavailable is set (#10328) * fix: selectDate not working with uncontrolled calendar and isDateUnavailable * simplify logic and add RAC test, fix lint, fix dates in tests * fix edge case * make ts a little smarter --------- Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
* chore: SideNav in test apps * turn on verdaccio * Revert "turn on verdaccio" This reverts commit 4973fd5.
…lback refs (#10451) CheckboxProps, SwitchProps, and RadioProps (and their Field variants) typed inputRef as RefObject, so a ref callback couldn't be passed even though mergeRefs already supports one. Widen inputRef to Ref on all six, widen useCheckboxAria's internal parameter to match, and memoize Switch's ref merge like Checkbox/Radio already do so a callback ref only tears down on unmount instead of every render. Closes #10319
* feat: add useShowFocusIndicator hook * test: simulate programmatic validation focus * test: wrap validation focus in act * test: simulate the programmatic focus directly, drop library framing * simplify test * test: correct focus indicator test description --------- Co-authored-by: Rob Snow <rsnow@adobe.com>
* chore: add a Claude.md file to help with contributions * improving AI contribution expectations * divvy up claude.md to task specific files * Update CONTRIBUTING.md Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> * review updates * code review * fix symlink --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
* Store the full selected range in TokenFieldValue * Improve token announcement and selection behavior * Add support for placeholder tokens in PromptField * fix lint * Fix showing autocomplete when clicking placeholder token * Only expand range around token when not collapsed * Collapse selection on blur but don't lose the position fixes inserting objects via plus menu * fix firefox and safari styling issues * useKeyboard * show menu on all tokens, not just placeholders * fix popover positioning when token is the first element * Add PromptField browser tests * back compat * raise resource class for browser tests * lint * try keyboard? * run tests in jsdom instead of browser * only set selection when it has changed * tab through all tokens
* fix: TokenField IME composition broken in Firefox * fix tests * fix lint --------- Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
github-actions
Bot
added
RAC
Checkbox
RadioGroup
Switch
AI
AttachmentList
HorizontalCard
PromptField
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )