[pull] main from adobe:main - #482
Merged
Merged
Conversation
…l orientation (#10467) * fix(actiongroup,tabs): keep ArrowLeft/Right consistent in RTL vertical orientation ArrowLeft/ArrowRight are flipped in RTL locales, but the flip was gated on orientation === 'horizontal'. In a vertical ActionGroup or TabList in an RTL locale the flip was skipped entirely, so ArrowRight moved focus to the next item and ArrowLeft to the previous one -- the opposite of the horizontal RTL pairings, and inconsistent with the rest of the arrow key handling. Drop the orientation check so ArrowLeft always moves to the next item and ArrowRight to the previous one in RTL, regardless of orientation. ArrowUp/ArrowDown never consult this flag, so vertical up/down navigation is unchanged. useToolbar has a similar-looking condition that is correct as written: it only handles ArrowLeft/Right when horizontal, so its orientation check is what stops ArrowDown from being flipped in RTL. * move tests and expand coverage * fix lint --------- Co-authored-by: Rob Snow <rsnow@adobe.com>
…#10474) * fix: auto set static color auto and fix tokenfield docs regex for IME * forgot to commit * add chromatic and make context propagate through menu trigger
* pixel loader design updates * Add focus ring for more contrast mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )