V0.8.0/agent smith

[gimlichael]

This pull request introduces the new agent-smith skill, a comprehensive software-craftsmanship advisor, and updates documentation and changelogs to reflect its addition. It also updates the description of the git-keep-a-changelog skill for greater accuracy and clarity, and adds compare links for changelog versions. The most important changes are summarized below:

---

New Skill: agent-smith

• Introduced the agent-smith skill, providing rigorous, evidence-driven guidance for a wide range of engineering tasks including design, architecture, implementation, refactoring, code review, testing, benchmarking, security, CI/CD, and repository governance. The skill is technology-neutral at its core, adapts to repository conventions, and emphasizes honest, consistent completion gates.
• Added detailed reference documentation, evaluation coverage, README installation instructions, a capability showcase, and a hero image asset for agent-smith. [1] [2] [3] [4]

Documentation and Changelog Updates

• Updated the CHANGELOG.md to include agent-smith in the 0.8.0 release, with a detailed summary of its features and principles.
• Improved the description of the git-keep-a-changelog skill in both the changelog and README for accuracy and to reflect workflow changes, including more precise handling of commit ranges and concrete releases. [1] [2]
• Added an [Unreleased] compare link to the changelog for easier navigation between versions.

[greptile-apps]

Greptile Summary

This PR introduces the agent-smith skill — a technology-neutral software-craftsmanship advisor with progressive disclosure, 13 eval cases, a Roslyn multi-project artifact repair script, and 15 specialist reference documents. It also replaces the git-keep-a-changelog caret-notation scope approach with a deterministic resolve-release-scope.ps1 resolver and adds a deterministic commit-subject validator to git-visual-commits.

• agent-smith skill: new SKILL.md with explicit .NET conformance lock, task-classification routing table, and completion criteria; repair script handles only the proven namespace-conversion artifact pattern and fails closed on all other shapes.
• git-keep-a-changelog scope refactor: resolver script emits history_range / diff_range separation, SHA-pins boundaries, and bleed-guards via an exception; SKILL.md Step 3b and Step 4 are rewritten to consume resolver output directly rather than constructing ranges manually.
• git-visual-commits subject validation: deterministic validate-commit-subject.ps1 enforcing emoji table membership, one ASCII space, lowercase start, and 70-character grapheme-cluster limit; CI validator content-checks the test file but does not execute it, unlike the agent-smith repair test which runs unconditionally.

Confidence Score: 5/5

Safe to merge. The changes are additive skill definitions, documentation, and PowerShell tooling with no runtime impact on production systems.

All three new scripts are well-scoped, fail-closed PowerShell utilities with no network access or shell-injection risk. The findings are documentation and testing-consistency observations that do not affect the correctness of the scripts themselves.

scripts/validate-skill-templates.ps1 — the new git-visual-commits block content-checks test-commit-subject.ps1 but never executes it, which is inconsistent with how the agent-smith repair test is handled in the same PR.

Important Files Changed

Filename	Overview
skills/agent-smith/SKILL.md	New skill entry point: well-structured progressive disclosure, technology-neutral core, clear .NET conformance lock at the top, reference routing table, and explicit completion criteria. Within the 500-line limit.
skills/agent-smith/evals/evals.json	13 eval cases covering proportional implementation, benchmark mode, API review, CI/CD, TypeScript non-.NET scope, out-of-scope creative writing, and seven EditorConfig/Roslyn remediation scenarios with specific expectation lists.
skills/agent-smith/scripts/repair-roslyn-multiproject-artifacts.ps1	Deterministic Roslyn merge-artifact repair: detects whole-document namespace-conversion pattern, validates prefix coherence before apply, preserves BOM encoding, exits 2 on unsafe artifacts, and fails closed on any unrecognized pattern.
skills/git-keep-a-changelog/scripts/resolve-release-scope.ps1	New deterministic branch-scope resolver: discovers default base via upstream tracking, pins SHAs, emits history_range/diff_range separation, and bleed-guards via throw. The base_history_bleed field in the output is always $false (bleed causes a throw, not a flag), making the SKILL.md check redundant.
skills/git-visual-commits/scripts/validate-commit-subject.ps1	Deterministic commit-subject validator enforcing emoji table membership, single ASCII space, lowercase first character, opt-in conventional prefix, and 70-char grapheme-cluster limit. Contains an undocumented hardcoded 🎭 approval bypass with no associated test case.
skills/git-visual-commits/scripts/test-commit-subject.ps1	10 test cases covering valid subjects, the reported screenshot regression, double-space separator, overlong subject, forbidden prefix, and invalid prefix in combo mode. Never executed by the CI validator — only its content is needle-checked.
scripts/validate-skill-templates.ps1	Adds three validation blocks: agent-smith EditorConfig/Roslyn coverage (executes repair test unconditionally), git-visual-commits subject lock (content-checks only, does not execute test-commit-subject.ps1), and git-keep-a-changelog scope-resolver checks (executes resolver test locally only). Inconsistent execution strategy between the three new blocks.
skills/git-keep-a-changelog/SKILL.md	Refactored scope resolution from manual caret-notation to the bundled resolver script; adds yolo committed-history isolation rule, release isolation checkpoint as non-negotiable #2, and rewrites Step 1/3b/4 to use emitted ranges directly.
CHANGELOG.md	0.8.0 summary updated to include agent-smith alongside dotnet-benchmark; added agent-smith Added/Changed/Fixed bullets; added Unreleased compare link footer.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User invokes /agent-smith task] --> B{Classify task modes}
    B -->|.NET EditorConfig| C[Load dotnet.md + dotnet-editorconfig-conformance.md]
    B -->|Architecture / API / etc.| D[Load relevant reference docs]
    C --> E{Prior mutating formatter pass?}
    E -->|Yes - Unmerged artifacts| F[repair-roslyn-multiproject-artifacts.ps1 check mode]
    F -->|all recoverable| G[Run with -Apply]
    F -->|unsafe artifact| H[Fail closed - report blocker]
    E -->|No| I[dotnet format --severity info --verify-no-changes]
    I --> J{Clean?}
    J -->|No| K[Deliberate source edits]
    K --> I
    J -->|Yes| L[Build + tests]

    M[User invokes git-keep-a-changelog] --> N[resolve-release-scope.ps1]
    N -->|bleed detected| O[Throw - stop]
    N -->|clean JSON| P[history_range for commits]
    N --> Q[diff_range for manifest diffs]
    P --> R[Write CHANGELOG.md]
    Q --> R

    S[User commits via git-visual-commits] --> T[Read SKILL.md EOF]
    T --> U[validate-commit-subject.ps1 pre-plan]
    U -->|fail| V[Halt and report]
    U -->|pass| W[Stage + commit]
    W --> X[validate-commit-subject.ps1 pre-git]
    X -->|fail| V
    X -->|pass| Y[git bot commit]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[User invokes /agent-smith task] --> B{Classify task modes}
    B -->|.NET EditorConfig| C[Load dotnet.md + dotnet-editorconfig-conformance.md]
    B -->|Architecture / API / etc.| D[Load relevant reference docs]
    C --> E{Prior mutating formatter pass?}
    E -->|Yes - Unmerged artifacts| F[repair-roslyn-multiproject-artifacts.ps1 check mode]
    F -->|all recoverable| G[Run with -Apply]
    F -->|unsafe artifact| H[Fail closed - report blocker]
    E -->|No| I[dotnet format --severity info --verify-no-changes]
    I --> J{Clean?}
    J -->|No| K[Deliberate source edits]
    K --> I
    J -->|Yes| L[Build + tests]

    M[User invokes git-keep-a-changelog] --> N[resolve-release-scope.ps1]
    N -->|bleed detected| O[Throw - stop]
    N -->|clean JSON| P[history_range for commits]
    N --> Q[diff_range for manifest diffs]
    P --> R[Write CHANGELOG.md]
    Q --> R

    S[User commits via git-visual-commits] --> T[Read SKILL.md EOF]
    T --> U[validate-commit-subject.ps1 pre-plan]
    U -->|fail| V[Halt and report]
    U -->|pass| W[Stage + commit]
    W --> X[validate-commit-subject.ps1 pre-git]
    X -->|fail| V
    X -->|pass| Y[git bot commit]

Loading

_{Reviews (4): Last reviewed commit: "💬 update README for agent-smith Roslyn ..." | Re-trigger Greptile}