ci: Raise the Node baseline from 20 to 22 - #139
Merged
Conversation
jsdom 30 raised its floor to ^22.22.2 || ^24.15.0 || >=26.0.0. On Node 20 the vitest jsdom environment fails to load — jsdom's undici calls webidl.util.markAsUncloneable, which does not exist there — so every fork worker dies at startup and the browser-mutation job reports "no tests" with 0% coverage (see the failure on dependabot PR #137). Node 20 is also past end-of-life, so pin both CI jobs to Node 22 (latest 22.x is v22.23.1, above jsdom's floor) rather than holding the dev dependency back, and align the SDK's engines field and the documented prerequisites. Verified against a scratch install of jsdom 30.0.1 on Node 22: 10 test files / 103 tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
wolpert
enabled auto-merge (rebase)
July 29, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the
browser-mutationCI job, which fails on #137's jsdom 29 → 30 bump.Why
jsdom 30.0.0 raised its floor to
^22.22.2 || ^24.15.0 || >=26.0.0. Both CI jobs pinnode-version: '20', where jsdom's undici callswebidl.util.markAsUncloneable— a function Node 20 does not have. Every vitest fork worker dies at startup:The job then reports
Test Files no testswith 0% coverage and exits 1.npm cidoesn't catch the mismatch because npm doesn't enforceengineswithoutengine-strict.Node 20 is past end-of-life, so raising the baseline beats pinning the dev dependency a major behind.
Changes
.github/workflows/ci.yml—browser-mutationande2ejobs move tonode-version: '22'(latest 22.x is v22.23.1, above jsdom's floor)clients/passkeys-browser/package.json—engines.node→>=22.22.2README.md/RELEASE.md/CLAUDE.md— documented prerequisite updatedVerification
Scratch install of jsdom 30.0.1 against the current test suite on Node 22: 10 test files / 103 tests pass. On Node 20 the same install reproduces the CI failure.
After this merges,
@dependabot rebaseon #137 should go green.🤖 Generated with Claude Code