build(deps): Hold logback on the 1.5 line - #140
Merged
Conversation
logback 1.6.0 removed ch.qos.logback.classic.PatternLayout.DEFAULT_CONVERTER_MAP.
Dropwizard 5's dropwizard-request-logging reads that field in a static
initializer, so with logback 1.6.1 on the classpath every Dropwizard app dies at
boot:
java.lang.NoSuchFieldError: Class ch.qos.logback.classic.PatternLayout
does not have member field 'java.util.Map DEFAULT_CONVERTER_MAP'
at io.dropwizard.request.logging.layout.LogbackAccessRequestLayout.<clinit>
That is what fails dependabot PR #138 — 16 integration tests in
:pk-auth-dropwizard plus the dropwizard-demo e2e run. Dropwizard 5.0.2 is the
newest release and still resolves logback 1.5.x, so ignore minor and major
logback updates until Dropwizard supports 1.6. Patch updates on 1.5.x still flow.
The minor entry matters: 1.5 -> 1.6 is a semver-minor bump, so a major-only
ignore (as used for Micronaut) would not have held the line.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
wolpert
enabled auto-merge (rebase)
July 29, 2026 14:15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #138, which fails on its
logback 1.5.38 → 1.6.1bump.Why
logback 1.6.0 removed
ch.qos.logback.classic.PatternLayout.DEFAULT_CONVERTER_MAP. Dropwizard 5'sdropwizard-request-loggingreads that field in a static initializer, so with 1.6.1 on the classpath every Dropwizard app dies at boot:On #138 that took out 16 integration tests in
:pk-auth-dropwizard(PkAuthBundleIntegrationTest,PkAuthBundleAltFlowsIntegrationTest— everything that boots the app) and thee2e (dropwizard-demo)job, where:examples:dropwizard-demo:runfailed at startup with the same trace.Dropwizard 5.0.2 resolves
logback-classic:1.5.33; the catalog force-upgrades the classpath to 1.6.1 (dependencyInsightshows1.5.33 -> 1.6.1). Dropwizard 5.0.2 is the newest release on Maven Central, so there is no upgrade path out of the conflict yet.Change
One ignore entry in
.github/dependabot.ymlforch.qos.logback:*, covering minor and major updates — 1.5 → 1.6 is a semver-minor bump, so the major-only form used for Micronaut would not hold the line. Patch updates on 1.5.x still flow. Remove this once Dropwizard ships logback 1.6 support.Verification
Reproduced on the #138 branch locally, then reverted only
logbackto 1.5.38 —./gradlew :pk-auth-dropwizard:testgoes BUILD SUCCESSFUL, confirming the other two bumps in that PR (spotless 8.9.0, aws-sdk 2.49.5) are fine.Once this merges,
@dependabot recreateon #138 regenerates it without the logback bump.🤖 Generated with Claude Code