Fix Package Settings menu: correct ${packages} path to 'Markdown Table of Contents'#5
Open
AntonioGHub wants to merge 1 commit into
Open
Conversation
The Main.sublime-menu referenced ${packages}/mdtoc/..., but the plugin
is distributed via Package Control as "Markdown Table of Contents", so
Sublime resolves ${packages} to Packages/Markdown Table of Contents/.
Both "Settings - Default" and "Key Bindings - Default" menu entries
therefore failed with:
The settings file "res://Packages/mdtoc/mdtoc.sublime-settings"
could not be opened
Update both base_file paths to use the actual package name. Also drop
a trailing comma in the keymap entry (invalid JSON tolerated by ST's
parser but rejected by strict linters).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
Summary
The
Main.sublime-menureferences${packages}/mdtoc/..., but the plugin is distributed through Package Control asMarkdown Table of Contents, so Sublime resolves${packages}toPackages/Markdown Table of Contents/. As a result, both Package Settings menu entries fail with:(and analogously for
Default.sublime-keymap).What the PR changes
Update both
base_filepaths inMain.sublime-menufrom${packages}/mdtoc/...→${packages}/Markdown Table of Contents/...so they resolve against the package's actual installed name.