Fix firebase-app-distribution release ordering rejected by the Firebase API#501
Merged
priitlatt merged 1 commit intoJul 15, 2026
Merged
Conversation
Firebase's `releases.list` API now strictly validates `orderBy` and rejects the previously tolerated `createTimeDesc`, breaking `get-latest-build-version` and `releases list`. Send the documented `createTime desc` grammar instead. The API value is decoupled from the `--order-by` CLI token via a new tool-layer `ReleasesOrderByArgument`, so the CLI interface stays backwards compatible (`--order-by createTimeDesc` still works). Resolves #500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since around 2026-07-14,
firebase-app-distribution get-latest-build-versionandfirebase-app-distribution releases liststarted failing withRequest contains an invalid argument.for every app, with no changes on our side (reported in #500).The Firebase App Distribution
releases.listAPI now rejects the previously tolerated camelCasecreateTimeDesc. The documented grammar uses a space-separateddescsuffix, i.e.createTime desc.The catch is that
OrderBy.valuewas doing double duty: it was both the value sent to the API and the token accepted by the public--order-byCLI argument. Simply changing it tocreateTime descwould fix the API call but break the CLI (--order-by createTimeDescwould stop working and the value would need quoting). This PR decouples the two.Changes
codemagic.google.resources.firebase.OrderBynow holds the documented API grammar (createTime desc/createTime) — this is the value sent toreleases.list.ReleasesOrderByArgumentin the tool layer (argument_types.py) that keeps the single-token values (createTimeDesc/createTime) and maps toOrderByvia itsorder_byproperty. The--order-byargument and thelist_releasesaction signatures now use this type, converting toOrderByat the point where the action group calls into the service.Effect
firebase-app-distribution get-latest-build-versionandfirebase-app-distribution releases listwork again against the updated API.--order-byCLI interface is unchanged and fully backwards compatible: samecreateTimeDesc/createTimechoices andcreateTimeDescdefault, and the generated docs are unchanged.QA reference