Skip to content

bug: Weekly Target progress resets to totalSolved on transient API failure (#297) #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashvi-3106 wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −22
Open

bug: Weekly Target progress resets to totalSolved on transient API failure (#297) #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 48 additions & 22 deletions frontend/js/user/goal-setter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,31 +117,44 @@
}

async function fetchSolvedCount(metric) {
try {
const res = await fetch("/api/user/" + username);
if (!res.ok) return 0;
const data = await res.json();
var history = data.history;
if (!Array.isArray(history) || history.length === 0) return 0;
var latest = history[history.length - 1];
if (metric === "easy") return Number(latest.easy) || 0;
if (metric === "medium") return Number(latest.medium) || 0;
if (metric === "hard") return Number(latest.hard) || 0;
return (
(Number(latest.easy) || 0) +
(Number(latest.medium) || 0) +
(Number(latest.hard) || 0)
);
} catch {
return 0;
const res = await fetch("/api/user/" + username);
if (!res.ok) {
throw new Error("Failed to fetch solved count: " + res.status);
}
const data = await res.json();
const history = data.history;
if (!Array.isArray(history) || history.length === 0) return 0;
const latest = history[history.length - 1];
if (metric === "easy") return Number(latest.easy) || 0;
if (metric === "medium") return Number(latest.medium) || 0;
if (metric === "hard") return Number(latest.hard) || 0;
return (
(Number(latest.easy) || 0) +
(Number(latest.medium) || 0) +
(Number(latest.hard) || 0)
);
}

async function render() {
const goal = loadGoal(username);
if (goal) {
const solved = await fetchSolvedCount(goal.metric);
showProgress(goal, solved);
try {
const solved = await fetchSolvedCount(goal.metric);
showProgress(goal, solved);
} catch (e) {
console.error("Error loading goal progress:", e);
elLabel.textContent =
"TARGET: " +
goal.target +
" " +
goal.metric.toUpperCase() +
" / WEEK";
elBar.textContent = "[ FAILED TO SYNC PROGRESS ]";
elBar.style.color = "var(--red)";
elCount.textContent = "API error, please refresh later";
elDisplay.style.display = "block";
elSetter.style.display = "none";
}
} else {
showSetter();
}
Expand All @@ -155,9 +168,22 @@
return;
}
elInput.style.borderColor = "";
const goal = saveGoal(username, metric, target);
const solved = await fetchSolvedCount(metric);
showProgress(goal, solved);

try {
const solved = await fetchSolvedCount(metric);
const goal = saveGoal(username, metric, target);
showProgress(goal, solved);
} catch (e) {
console.error("Error setting goal:", e);
elInput.style.borderColor = "#ff4c4c";
elInput.value = "";
elInput.placeholder = "API Error, retry";
}
});

elInput.addEventListener("focus", function () {
elInput.placeholder = "e.g. 10";
elInput.style.borderColor = "";
});

elReset.addEventListener("click", function () {
Expand Down
Loading