fix(tests): scope test_upsert_replaces_record's filter to the record's own id - #2779
Draft
andersfylling wants to merge 2 commits into
Draft
fix(tests): scope test_upsert_replaces_record's filter to the record's own id#2779andersfylling wants to merge 2 commits into
andersfylling wants to merge 2 commits into
Conversation
…s own id The filter matched only on value=99.0, a literal shared by every concurrent CI run (10-way OS/Python matrix against the same project). Two runs upserting around the same time would see each other's records and fail the single-match assertion. Filtering by the record's own space/externalId (which embeds a per-test uuid) avoids the collision; the value check moves to asserting on the returned record's properties instead. Also removes the temporary skip added for this test, since it addresses the likely root cause. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2779 +/- ##
==========================================
- Coverage 93.06% 93.04% -0.02%
==========================================
Files 514 514
Lines 52988 52990 +2
==========================================
- Hits 49311 49305 -6
- Misses 3677 3685 +8
🚀 New features to boost your workflow:
|
andersfylling
marked this pull request as ready for review
August 21, 2026 11:54
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the test_upsert_replaces_record integration test by removing the temporary skip decorator. Additionally, it refactors the query filter within the test to use an And filter matching on space and externalId instead of an Equals filter, and adds assertions to verify the correctness of the returned record's properties. There are no review comments, and I have no further feedback to provide.
andersfylling
marked this pull request as draft
August 21, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given we run the test suite in parallel, we need to scope the relevant records to the current test implementation. Otherwise our expects records may not be part of the final result set.