fix(functions): list schedules with function external id - #2783
Open
MortGron wants to merge 3 commits into
Open
Conversation
MortGron
marked this pull request as ready for review
August 23, 2026 08:40
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2783 +/- ##
==========================================
+ Coverage 93.03% 93.06% +0.03%
==========================================
Files 515 515
Lines 53006 53017 +11
==========================================
+ Hits 49313 49340 +27
+ Misses 3693 3677 -16
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the function schedules listing API to retrieve and filter by a function's internal ID when an external ID is provided, returning an empty list if the function is not found. It also bumps the pytest dependency to >=9 and adds integration tests for these changes. However, the new tests introduce the subtests fixture, which requires the pytest-subtests package that is not declared in the project dependencies.
haakonvt
reviewed
Aug 23, 2026
Contributor
|
@HMEiding could you take a quick look on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specifying
function_external_idinschedules.listalways return an empty list even though schedules exists:Pytest has been updated to v9 to support subtests
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.