feat(state time series): add retrieve_arrays support for raw state datapoints - #2812
Open
haakonvt wants to merge 10 commits into
Open
feat(state time series): add retrieve_arrays support for raw state datapoints#2812haakonvt wants to merge 10 commits into
haakonvt wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements support for retrieving raw state datapoints using retrieve_arrays(...) by handling state datapoints in the underlying numpy unpacking and result generation tasks, and adding numeric_states and string_states attributes to DatapointsArray. The review feedback highlights a critical bug where indexing, slicing, or dumping the retrieved state datapoints will fail or result in data loss due to plural vs singular attribute mismatches (e.g., numeric_states vs numeric_state) and their omission from DatapointsArray._data_fields.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## add-state-ts-retrieve-support-pandas #2812 +/- ##
========================================================================
- Coverage 93.15% 93.13% -0.03%
========================================================================
Files 516 516
Lines 53788 53832 +44
========================================================================
+ Hits 50106 50135 +29
- Misses 3682 3697 +15
🚀 New features to boost your workflow:
|
haakonvt
force-pushed
the
add-state-ts-retrieve-arrays-support
branch
from
September 4, 2026 10:52
0bc4fb8 to
9b440ea
Compare
haakonvt
force-pushed
the
add-state-ts-retrieve-arrays-support
branch
from
September 7, 2026 20:05
9b440ea to
08de949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
DatapointsArraywithnumeric_statesandstring_statesand adds support for retrieving (possibly nullable) raw state datapoints usingretrieve_arrays(using numpy).As Gemini is pointing out, some slicing mechanics is missing. This is planned as a separate PR.