Skip to content

[CDF-28552] Add dataProductScope support to dataProductsAcl - #3205

Merged
Magssch merged 7 commits into
mainfrom
add-dataproductsscope
Sep 8, 2026
Merged

[CDF-28552] Add dataProductScope support to dataProductsAcl#3205
Magssch merged 7 commits into
mainfrom
add-dataproductsscope

Conversation

@Magssch

@Magssch Magssch commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Add dataProductScope as a recognized scope for dataProductsAcl, mirroring the existing spaceIdScope pattern. Groups scoped to specific data products by external ID are now classified as resource-scoped, deploy after the referenced data products, and are validated as build/deploy dependencies.

Bump

  • Patch
  • Skip

Changelog

Added

  • Toolkit will now no longer reports an error when scoping the dataProductsAcl capability to specific data products via dataProductScope.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
44376 37484 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/client/resource_classes/group/init.py 100% 🟢
cognite_toolkit/_cdf_tk/client/resource_classes/group/acls.py 99% 🟢
cognite_toolkit/_cdf_tk/client/resource_classes/group/scopes.py 96% 🟢
cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/auth.py 73% 🟢
cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/group_scoped.py 100% 🟢
cognite_toolkit/_cdf_tk/yaml_classes/capabilities.py 98% 🟢
TOTAL 94% 🟢

updated for commit: f12e30f by action🐍

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (0bbf41e) to head (f12e30f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...toolkit/_cdf_tk/resource_ios/_resource_ios/auth.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files         476      476           
  Lines       44360    44376   +16     
=======================================
+ Hits        37470    37484   +14     
- Misses       6890     6892    +2     
Files with missing lines Coverage Δ
.../_cdf_tk/client/resource_classes/group/__init__.py 100.00% <ø> (ø)
...lkit/_cdf_tk/client/resource_classes/group/acls.py 98.81% <100.00%> (ø)
...it/_cdf_tk/client/resource_classes/group/scopes.py 96.19% <100.00%> (+0.11%) ⬆️
..._cdf_tk/resource_ios/_resource_ios/group_scoped.py 100.00% <100.00%> (ø)
...gnite_toolkit/_cdf_tk/yaml_classes/capabilities.py 98.23% <100.00%> (+0.01%) ⬆️
...toolkit/_cdf_tk/resource_ios/_resource_ios/auth.py 72.65% <81.81%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Magssch

Magssch commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@Magssch
Magssch marked this pull request as ready for review September 8, 2026 07:48
@Magssch
Magssch requested review from a team as code owners September 8, 2026 07:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for DataProductScope within the toolkit's group and capability resource classes. It adds the DataProductScope class to both client and YAML capabilities, updates DataProductsAcl to accept this new scope, and integrates dependency resolution for data products in GroupIO and GroupResourceScopedCRUD. Corresponding unit tests have also been added to verify the new scope's functionality. I have no feedback to provide.

@Magssch
Magssch enabled auto-merge (squash) September 8, 2026 07:57
@Magssch
Magssch merged commit 3a95bab into main Sep 8, 2026
13 checks passed
@Magssch
Magssch deleted the add-dataproductsscope branch September 8, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants