[CDF-28552] Add dataProductScope support to dataProductsAcl - #3205
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
=======================================
Coverage 84.46% 84.46%
=======================================
Files 476 476
Lines 44360 44376 +16
=======================================
+ Hits 37470 37484 +14
- Misses 6890 6892 +2
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for DataProductScope within the toolkit's group and capability resource classes. It adds the DataProductScope class to both client and YAML capabilities, updates DataProductsAcl to accept this new scope, and integrates dependency resolution for data products in GroupIO and GroupResourceScopedCRUD. Corresponding unit tests have also been added to verify the new scope's functionality. I have no feedback to provide.
Description
Add
dataProductScopeas a recognized scope fordataProductsAcl, mirroring the existingspaceIdScopepattern. Groups scoped to specific data products by external ID are now classified as resource-scoped, deploy after the referenced data products, and are validated as build/deploy dependencies.Bump
Changelog
Added
dataProductsAclcapability to specific data products viadataProductScope.