Skip to content

[CDF-28561]🫡Fix failing smoke tests - #3211

Merged
doctrino merged 7 commits into
mainfrom
fix-failing-smoke-tests
Sep 8, 2026
Merged

[CDF-28561]🫡Fix failing smoke tests#3211
doctrino merged 7 commits into
mainfrom
fix-failing-smoke-tests

Conversation

@doctrino

@doctrino doctrino commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Two issues for the new transformation external data source

  • The docs URL was wrong. Fixed it now.
  • The endpoints returns a 500. I decided to simply check for it. Then, when it is fixed we can do proper testing of it.

Bump

  • Patch
  • Skip

@doctrino
doctrino requested review from a team as code owners September 7, 2026 17:27
@doctrino
doctrino enabled auto-merge (squash) September 7, 2026 17:27
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
44378 37485 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/client/api/transformation_externaldata.py 96% 🟢
cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/externaldata.py 99% 🟢
TOTAL 98% 🟢

updated for commit: 01b6827 by action🐍

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (3a95bab) to head (01b6827).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../_cdf_tk/client/api/transformation_externaldata.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
- Coverage   84.46%   84.46%   -0.01%     
==========================================
  Files         476      476              
  Lines       44376    44378       +2     
==========================================
+ Hits        37484    37485       +1     
- Misses       6892     6893       +1     
Files with missing lines Coverage Δ
..._cdf_tk/resource_ios/_resource_ios/externaldata.py 99.04% <100.00%> (ø)
.../_cdf_tk/client/api/transformation_externaldata.py 96.00% <75.00%> (-4.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/externaldata.py Outdated
@doctrino
doctrino requested a review from ronpal September 8, 2026 07:48
ronpal
ronpal previously approved these changes Sep 8, 2026
# Conflicts:
#	cognite_toolkit/_cdf_tk/resource_ios/_resource_ios/externaldata.py
@doctrino
doctrino merged commit 8112490 into main Sep 8, 2026
13 checks passed
@doctrino
doctrino deleted the fix-failing-smoke-tests branch September 8, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants