Skip to content

[CDF-28567] 🌅Remove unused warnings - #3217

Open
doctrino wants to merge 37 commits into
mainfrom
remove-unused-warnings
Open

[CDF-28567] 🌅Remove unused warnings#3217
doctrino wants to merge 37 commits into
mainfrom
remove-unused-warnings

Conversation

@doctrino

@doctrino doctrino commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unused warnings

Bump

  • Patch
  • Skip

@doctrino
doctrino requested review from a team as code owners September 8, 2026 03:59
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
42855 36683 86% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/tk_warnings/init.py 100% 🟢
cognite_toolkit/_cdf_tk/tk_warnings/fileread.py 73% 🟢
cognite_toolkit/_cdf_tk/tk_warnings/other.py 82% 🟢
cognite_toolkit/_cdf_tk/validation.py 99% 🟢
TOTAL 89% 🟢

updated for commit: cf69e7d by action🐍

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.59%. Comparing base (a285039) to head (cf69e7d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...te_toolkit/_cdf_tk/data_classes/_deploy_results.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
+ Coverage   85.03%   85.59%   +0.56%     
==========================================
  Files         466      460       -6     
  Lines       43830    42855     -975     
==========================================
- Hits        37271    36683     -588     
+ Misses       6559     6172     -387     
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/data_classes/__init__.py 100.00% <ø> (ø)
cognite_toolkit/_cdf_tk/data_classes/_base.py 66.66% <100.00%> (+13.00%) ⬆️
...gnite_toolkit/_cdf_tk/data_classes/_config_yaml.py 77.38% <100.00%> (+13.99%) ⬆️
cognite_toolkit/_cdf_tk/resource_ios/__init__.py 75.80% <100.00%> (-0.76%) ⬇️
cognite_toolkit/_cdf_tk/resource_ios/_base_ios.py 85.29% <ø> (-0.18%) ⬇️
cognite_toolkit/_cdf_tk/tk_warnings/__init__.py 100.00% <ø> (ø)
cognite_toolkit/_cdf_tk/tk_warnings/fileread.py 72.60% <100.00%> (+0.43%) ⬆️
cognite_toolkit/_cdf_tk/tk_warnings/other.py 82.45% <100.00%> (+9.66%) ⬆️
cognite_toolkit/_cdf_tk/utils/file.py 79.47% <100.00%> (+1.01%) ⬆️
cognite_toolkit/_cdf_tk/validation.py 99.13% <ø> (+14.28%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ronpal
ronpal previously approved these changes Sep 8, 2026
Base automatically changed from remove-unused-data-classes to main September 8, 2026 09:08
@doctrino
doctrino dismissed ronpal’s stale review September 8, 2026 09:08

The base branch was changed.

@doctrino
doctrino requested a review from ronpal September 8, 2026 09:08
@doctrino
doctrino enabled auto-merge (squash) September 8, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants