[CDF-28563] 🪧Remove resource worker - #3220
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
faefa8b to
cf14380
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the deployment process by removing the ResourceWorker class and moving the resource categorization logic to DeployV2Command.categorize_resources. It also updates the create method in FunctionScheduleLoader to manually set the data attribute from the request. Feedback on the changes suggests using loader.get_id(resource) instead of resource.as_id() in the test utilities and integration tests to ensure consistency and prevent potential AttributeErrors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
==========================================
- Coverage 85.61% 85.58% -0.03%
==========================================
Files 460 459 -1
Lines 42872 42780 -92
==========================================
- Hits 36704 36614 -90
+ Misses 6168 6166 -2
🚀 New features to boost your workflow:
|
Description
Resource worker was used in deploy v1, and is no longer necessary. It is replaced by
DeployV2Command.categorize_resourcesBump