Handle "none" channels (e.g. hue of white in OKLCh)#240
Open
DmitrySharabin wants to merge 1 commit into
Open
Conversation
Color.js returns null for "none" channel values. Previously this crashed color-picker when initialized with such colors (e.g. `color="white"`). - color-slider: guard `colorAt` against null, hide thumb via `:state(no-value)`, replace none coords in gradient stops with 0 - channel-slider: pass null through to spinner as empty string - hue-wheel: hide marker when `hueValue` is null, announce "none" in ARIA Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for color-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorAtagainst null values, hide thumb via:state(no-value), replace "none" coords in gradient stops with 0hueValueis null (covers both missing color and "none" hue), announce "none" in ARIA valuetextFixes
<color-picker color="white">crashing — Color.js returnsnullfor "none" channel values (e.g. hue of white in OKLCh), which previously causedtoPrecisioncalls on null.Test plan
<color-picker color="white">renders without error, hue slider has no thumb<color-picker color="black">same behavior<color-picker color="oklch(none none none)">all three sliders have no thumb<hue-wheel color="white">shows no marker; clicking the wheel seeds one🤖 Generated with Claude Code