Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What it covers
organisation_nameon the Copy tab, clicks Save, confirmssettings-updated=trueredirect, reloads, and asserts the database value persisted. Restores the original value so local re-runs are idempotent.Notable implementation decisions
scripts/setup.phpnow pre-populates the three required Copy-tab fields plus one membership plan so Carbon Fields' save button and cross-validator stay unlocked in the test environment.test.afterAllhook restoresstripe_direct_debit_only=trueviawp evalafter the round-trip, because Carbon Fields saves the entire container and would otherwise wipe options that aren't mirrored as visible form fields.Test plan
cd packages/join-e2e && npx wp-env startbash scripts/seed.shnpx playwright test tests/wp-admin-smoke.spec.ts --reporter=list— both tests passnpx playwright test --reporter=list— full suite passes (59 tests across 9 spec files)trigger_error(..., E_USER_ERROR)toSettings.php::registerSettings) and re-run — both tests must fail. Revert and confirm green again.Suite count
Was: 57 tests / 8 spec files
Now: 59 tests / 9 spec files