feat: add complypack validate command by hbraswelrh · Pull Request #216 · complytime/complypack

hbraswelrh · 2026-07-30T14:22:09Z

Summary

Add a standalone complypack validate command that validates complypack.yaml configuration files against the JSON Schema and structural rules (closes #143).

Changes

CLI: complypack validate [path] [--strict] — validates config, defaults to complypack.yaml in current directory. Unknown fields warn by default, error with --strict.
MCP: validate_config tool with path (required) and strict (optional) parameters. Returns isError: true on validation failure.
Tests: 12 new test cases across CLI (validate_test.go) and MCP (tools_test.go).

Design

Both layers are thin transport wiring over config.LoadConfig(path, strict, writer) — no new domain logic. Follows the project's architecture pattern of keeping business logic in domain packages.

Files Changed

File	Action
`cmd/complypack/cli/validate.go`	New — CLI command
`cmd/complypack/cli/validate_test.go`	New — 6 CLI test scenarios
`cmd/complypack/cli/root.go`	Modified — register validateCmd
`internal/mcp/tools.go`	Modified — validate_config tool + handler
`internal/mcp/tools_test.go`	Modified — 4 MCP test cases
`internal/mcp/server.go`	Modified — register tool

trevor-vaughan

We need a README.md update for the new capabilities.

Sorry about the slightly rambling comments, I ended up having to do more dumpster diving than I expected to make sure I was understanding things properly.

trevor-vaughan · 2026-07-30T22:42:39Z

+	orig, err := os.Getwd()
+	require.NoError(t, err)
+	require.NoError(t, os.Chdir(dir))
+	t.Cleanup(func() { _ = os.Chdir(orig) })


Should we capture the restore error here just in case there's an issue? Or perhaps use a single t.Chdir(dir) call for automatic cleanup?

Addressed in db8261d: Replaced manual os.Chdir/t.Cleanup with t.Chdir(dir).

yvonnedevlinrh

I agree with all of @trevor-vaughan's findings:

Command naming (blocking): The bare validate name is reserved by ADR 019 for the validate_policy CLI equivalent. This needs namespacing (e.g., config validate or validate-config) to avoid a breaking rename later.
Validation depth (blocking): LoadConfig only runs basic checks (version presence, format patterns, platform non-empty). It doesn't call ValidateForPack, ValidateForMCP, or ValidateForInit, so a passing result doesn't mean the config is actually ready for any operation.
Path sanitization (blocking): The MCP handler passes the user-supplied path directly to os.ReadFile with no sanitization, unlike other tools that go through the ResourceStore.
t.Chdir (non-blocking): Agree - t.Chdir(dir) is safer and available on Go 1.24+.
--strict naming (non-blocking): Either approach works; no strong preference from me.

I also left two inline comments on additional issues I found in the MCP handler code.

yvonnedevlinrh · 2026-07-31T10:45:11Z

+						Text: fmt.Sprintf("validation failed: %v", err),
+					},
+				},
+				IsError: true,


MEDIUM
IsError: true deviates from MCP handler convention — every other handler returns structured JSON with "valid": false; this one uses MCP-level error signaling

Addressed in 02414ea: Handler now returns structured JSON with valid, errors, warnings, and scopes fields — matching the validate_policy handler convention. IsError is no longer used for validation failures.

yvonnedevlinrh · 2026-07-31T10:46:52Z

 }
+
+// GetValidateConfigHandler exposes handler for testing.
+func GetValidateConfigHandler() mcp.ToolHandler {


MEDIUM
GetValidateConfigHandler() is dead code — exported "for testing" but zero callers, including tests

Addressed in 02414ea: Removed GetValidateConfigHandler().

@trevor-vaughan

Addresses PR complytime#216 review feedback from @trevor-vaughan. - Rename bare `validate` to `config validate` subcommand to avoid collision with ADR 019 reserved `validate` for validate_policy parity - Replace --strict flag with --unknown-fields=warn|error for clarity - Add --scope flag (pack/serve/init/all) for scope-specific validation using new ValidateScoped domain function - Replace manual os.Chdir with t.Chdir in tests (Go 1.24+) Signed-off-by: Hannah Braswell <hbraswelrh@users.noreply.github.com> Assisted-by: claude-opus-4-6

@yvonnedevlinrh

Addresses PR complytime#216 review feedback from @yvonnedevlinrh and @trevor-vaughan. - Return structured JSON with valid/errors/warnings/scopes fields instead of using IsError for validation failures (matches validate_policy handler convention) - Add scope parameter to validate_config tool schema - Rename strict to unknownFields in tool schema for consistency with CLI --unknown-fields flag - Add stdio transport security comment documenting path safety assumption - Remove dead GetValidateConfigHandler() export (zero callers) Signed-off-by: Hannah Braswell <hbraswelrh@users.noreply.github.com> Assisted-by: claude-opus-4-6

@trevor-vaughan

Addresses PR complytime#216 review feedback from @trevor-vaughan. - Document complypack config validate with flags and examples - Add validate_config to MCP tools table - Add .uf/feedback/ to .gitignore Signed-off-by: Hannah Braswell <hbraswelrh@users.noreply.github.com> Assisted-by: claude-opus-4-6

hbraswelrh · 2026-07-31T13:36:03Z

README update addressed in 03475e1: Added config validate documentation with flags, examples, and validate_config MCP tools table entry.

Add standalone config validation via CLI and MCP: - CLI: complypack validate [path] [--strict] Validates complypack.yaml against JSON Schema and structural rules. Defaults to complypack.yaml in current directory. Unknown fields warn by default, error with --strict. - MCP: validate_config tool with path and strict parameters. Returns isError:true on validation failure. Both layers are thin wiring over config.LoadConfig — no new domain logic added. Closes: complytime#143 Signed-off-by: Hannah Braswell <hbraswel@redhat.com>

@trevor-vaughan

Addresses PR complytime#216 review feedback from @trevor-vaughan. - Rename bare `validate` to `config validate` subcommand to avoid collision with ADR 019 reserved `validate` for validate_policy parity - Replace --strict flag with --unknown-fields=warn|error for clarity - Add --scope flag (pack/serve/init/all) for scope-specific validation using new ValidateScoped domain function - Replace manual os.Chdir with t.Chdir in tests (Go 1.24+) Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Assisted-by: claude-opus-4-6

@yvonnedevlinrh

Addresses PR complytime#216 review feedback from @yvonnedevlinrh and @trevor-vaughan. - Return structured JSON with valid/errors/warnings/scopes fields instead of using IsError for validation failures (matches validate_policy handler convention) - Add scope parameter to validate_config tool schema - Rename strict to unknownFields in tool schema for consistency with CLI --unknown-fields flag - Add stdio transport security comment documenting path safety assumption - Remove dead GetValidateConfigHandler() export (zero callers) Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Assisted-by: claude-opus-4-6

@trevor-vaughan

Addresses PR complytime#216 review feedback from @trevor-vaughan. - Document complypack config validate with flags and examples - Add validate_config to MCP tools table - Add .uf/feedback/ to .gitignore Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Assisted-by: claude-opus-4-6

Address divisor-testing REQUEST CHANGES findings: - Add Valid/Error field assertions to ValidateScoped AllScopes and EmptyScopes tests (was only checking structure, not correctness) - Strengthen MCP handler test assertions: verify response["valid"], response["errors"] content, and scope result validity - Add tests for invalid --scope and --unknown-fields flag values - Replace string concatenation with filepath.Join in MCP tests (SC-003) - Add GoDoc comments on configCmd and configValidateCmd (CS-004) Signed-off-by: Hannah Braswell <hbraswel@redhat.com> Assisted-by: claude-opus-4-6

hbraswelrh requested a review from a team as a code owner July 30, 2026 14:22

hbraswelrh requested review from em-redhat and yvonnedevlinrh July 30, 2026 14:22

hbraswelrh marked this pull request as draft July 30, 2026 14:22

hbraswelrh requested a review from trevor-vaughan July 30, 2026 15:48

hbraswelrh marked this pull request as ready for review July 30, 2026 16:26

trevor-vaughan requested changes Jul 30, 2026

View reviewed changes

yvonnedevlinrh requested changes Jul 31, 2026

View reviewed changes

hbraswelrh added 5 commits July 31, 2026 10:28

hbraswelrh force-pushed the opsx/validate-command branch from dbe5205 to ca6571b Compare July 31, 2026 14:30

trevor-vaughan mentioned this pull request Jul 31, 2026

bug: complypack.Config.Source provenance is never populated #221

Open

hbraswelrh requested a review from yvonnedevlinrh July 31, 2026 15:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add complypack validate command - #216

feat: add complypack validate command#216
hbraswelrh wants to merge 5 commits into
complytime:mainfrom
hbraswelrh:opsx/validate-command

hbraswelrh commented Jul 30, 2026

Uh oh!

trevor-vaughan left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trevor-vaughan Jul 30, 2026

Uh oh!

hbraswelrh Jul 31, 2026

Uh oh!

Uh oh!

yvonnedevlinrh left a comment •

edited

Loading

Uh oh!

yvonnedevlinrh Jul 31, 2026

Uh oh!

hbraswelrh Jul 31, 2026

Uh oh!

yvonnedevlinrh Jul 31, 2026

Uh oh!

hbraswelrh Jul 31, 2026

Uh oh!

hbraswelrh commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hbraswelrh commented Jul 30, 2026

Summary

Changes

Design

Files Changed

Uh oh!

trevor-vaughan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trevor-vaughan Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

hbraswelrh Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yvonnedevlinrh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvonnedevlinrh Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

hbraswelrh Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

yvonnedevlinrh Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

hbraswelrh Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

hbraswelrh commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yvonnedevlinrh left a comment •

edited

Loading