Introduce MachineSet scale test - #162
Draft
Jakob-Naucke wants to merge 4 commits into
Draft
Conversation
and drift cache. Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: AI
Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: AI
1 task
uril
reviewed
Aug 17, 2026
| let client = self.test_ctx.client(); | ||
| let machine_name = &self.machine_name; | ||
|
|
||
| self.test_ctx.info("Cleaning up"); |
Contributor
There was a problem hiding this comment.
Perhaps start with setting replicas=0 for the machine-set (or is it done as part of the tests?)
Contributor
Author
There was a problem hiding this comment.
Good point, have added
uril
reviewed
Aug 17, 2026
| spec: MachineConfigSpec { | ||
| os_image_url: Some(bootc_image), | ||
| ..Default::default() | ||
| }, |
Contributor
There was a problem hiding this comment.
Wasn't there one more required configuration for a machine to become a node -- such that OpenShift accepts the custom RHCOS image ?
Contributor
Author
There was a problem hiding this comment.
None that I remember, but I can't really test it right now
uril
reviewed
Aug 17, 2026
| test_ctx.info("Updating MachineSet replicas to 0"); | ||
| let rp = Default::default(); | ||
| machinesets.replace(machine_name, &rp, &mset).await?; | ||
| scale_ctx.has_replicas(0, scaled_duration(60)).await?; |
Contributor
There was a problem hiding this comment.
nit: in a later PR we can write a function to update the machineset replicas (and possibly another one that also waits for the replicas to come up)
uril
reviewed
Aug 17, 2026
uril
left a comment
uril
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, with some comments
Jakob-Naucke
force-pushed
the
scale-test
branch
from
August 18, 2026 12:43
1920336 to
2e9723b
Compare
uril
reviewed
Aug 18, 2026
Create MachineConfig, MachineConfigPool & MachineSet. Includes pluggable modules for TEE platforms, and Azure as a first module. Test with 1 & 2 replicas. Test with a replica after deletion. Operator components are deployed in the same cluster, i.e. no bootstrap functionality. Will not work until coreos/fedora-coreos-tracker#2191 is resolved, but already gets to Azure machine creation (with no ignition) in this state. Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: AI
has an incompatible validation rule Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: AI
Jakob-Naucke
force-pushed
the
scale-test
branch
from
August 19, 2026 10:01
2e9723b to
132dd36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create MachineConfig, MachineConfigPool & MachineSet. Includes pluggable modules for TEE platforms, and Azure as a first module.
Test with 1 & 2 replicas. Test with a replica after deletion.
Operator components are deployed in the same cluster, i.e. no bootstrap functionality.
Will not work until coreos/fedora-coreos-tracker#2191 is resolved, but already gets to Azure machine creation (with no ignition) in this state.
In a separate, revertable commit, add a workaround for openshift/api#2978.
Before that, update operator and drift cache. Add a skill to do so.
Bundle build is expected to fail until trusted-execution-clusters/operator#337 is merged and can be pulled in.