-
Notifications
You must be signed in to change notification settings - Fork 59
Update docker.io/library/golang Docker tag to v1.26.4 (main) #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| ## Build | ||
|
|
||
| FROM docker.io/library/golang:1.26.3 AS build | ||
| FROM docker.io/library/golang:1.26.4 AS build | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-skew Go version skew between Dockerfile (now 1.26.4) and Dockerfile.dist (still go-toolset:1.26.3). These are different base images managed by separate Renovate rules, so temporary skew is expected. Confirm Dockerfile.dist will receive its own bump once go-toolset:1.26.4 is published. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-skew Go version skew between Dockerfile build image (now 1.26.4) and .tool-versions, go.mod, tools/go.mod, tools/kubectl/go.mod, acceptance/go.mod (all still 1.26.3). These are managed by separate Renovate rules and the patch-level discrepancy is benign for Go compatibility guarantees. |
||
|
|
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] protected-path
This PR modifies Dockerfile, which is a protected infrastructure file requiring human approval. The PR has no linked issue providing authorization for the change. While the PR is a Renovate-managed patch bump of the Go base image (1.26.3 β 1.26.4), protected-path changes always require explicit human review and approval regardless of the change's nature.
Suggested fix: A human reviewer with infrastructure approval authority should verify and approve this Dockerfile change.