Skip to content

chore: update fullsend shim workflow #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fullsend-ai-fullsend wants to merge 1 commit into from
+0 −16
Closed

chore: update fullsend shim workflow #3387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/fullsend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
# Copyright The Conforma Contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0

# lint-workflow-size: max-lines=280

@fullsend-ai-review fullsend-ai-review Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] lint-enforcement

Removing the Apache-2.0 license header will break make lint. The Makefile lint target runs addlicense -s -check across the repo and .github/workflows/fullsend.yaml is not in the LICENSE_IGNORE exclusion list. After merge, addlicense will report a missing header and CI will fail.

Suggested fix: Either retain the license header (and fix the upstream template to include it), or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile with a justification comment.

@fullsend-ai-review fullsend-ai-review Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] convention-violation

All 9 other workflow files in .github/workflows/ include the Apache-2.0 license header. Removing it from fullsend.yaml alone creates an inconsistency. If the upstream template intentionally omits the header, the resolution should be coordinated rather than a one-sided removal.

# fullsend shim workflow (workflow_call mode)
# Routes events to agent workflows in .fullsend via workflow_call.
Expand Down
Loading